You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/08/15 17:24:05 UTC

[GitHub] piiswrong commented on a change in pull request #7416: update submoules with android fixes

piiswrong commented on a change in pull request #7416: update submoules with android fixes
URL: https://github.com/apache/incubator-mxnet/pull/7416#discussion_r133249270
 
 

 ##########
 File path: src/operator/c_lapack_api.h
 ##########
 @@ -73,8 +73,13 @@ using namespace mshadow;
 extern "C" {
 
   // Fortran signatures
-  #define MXNET_LAPACK_FSIGNATURE1(func, dtype) \
-    void func##_(char *uplo, int *n, dtype *a, int *lda, int *info);
+  #ifdef __ANDROID__
+    #define MXNET_LAPACK_FSIGNATURE1(func, dtype) \
+      int func##_(char* uplo, int* n, dtype* a, int* lda, int *info);
 
 Review comment:
   why does it need to be int?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services