You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jvrubel (via GitHub)" <gi...@apache.org> on 2026/01/29 12:47:27 UTC
[PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
jvrubel opened a new pull request, #21143:
URL: https://github.com/apache/camel/pull/21143
These changes facilitate the use of the jbang-it module for testing of camel-launcher.
Changes:
- parametrize the camel command
- add a system property to pass the camel command parameter
- add a simple test for camel-launcher for upstream use
- add a system property for link to camel launcher (test is disabled unless the property is filled)
- upgrade test container to Java 21 (due to upgrade of container OS, Java 17 is no longer supported)
- add a method to get Camel route PID due to changed syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "mcarlett (via GitHub)" <gi...@apache.org>.
mcarlett commented on code in PR #21143:
URL: https://github.com/apache/camel/pull/21143#discussion_r2741631761
##########
test-infra/camel-test-infra-cli/src/test/java/org/apache/camel/test/infra/cli/services/CliBuiltContainer.java:
##########
@@ -223,5 +230,23 @@ public CliBuiltContainerParams setDockerFile(String dockerFile) {
this.dockerFile = dockerFile;
return this;
}
+
+ public String getMainCommand() {
+ return mainCommand;
+ }
+
+ public CliBuiltContainerParams setMainCommand(String mainCommand) {
+ this.mainCommand = mainCommand;
+ return this;
+ }
+
+ public String getCamelLauncher() {
+ return camelLauncher;
+ }
+
+ public CliBuiltContainerParams setCamelLauncher(String camelLauncher) {
+ this.camelLauncher = camelLauncher;
+ return this;
+ }
Review Comment:
are those methods used in camel-test-infra-cli? if not maybe you can use this as parameter just in the IT module (camel-jbang-it) , it is easier and the context is correct
##########
test-infra/camel-test-infra-cli/src/test/java/org/apache/camel/test/infra/cli/common/CliProperties.java:
##########
@@ -21,6 +21,10 @@ public final class CliProperties {
public static final String DOCKERFILE = "cli.service.docker.file";
+ public static final String MAIN_COMMAND = "cli.service.command";
+
+ public static final String CAMEL_LAUNCHER = "cli.service.camel.launcher";
Review Comment:
as for the methods, I think we should use a simple system property in camel-jbang-it module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on code in PR #21143:
URL: https://github.com/apache/camel/pull/21143#discussion_r2741544847
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/MavenGradleITCase.java:
##########
@@ -41,11 +42,12 @@ public void runFromGradleTest() throws IOException {
execInContainer(String.format("mkdir %s/gradle-app", mountPoint()));
execInContainer(String.format("cd %s/gradle-app && camel init cheese.xml", mountPoint()));
Review Comment:
@jvrubel I just stumbled on it, is `camel init` correct here? shouldn't it be `getMainCommand()`?
There may be other issues like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21143:
URL: https://github.com/apache/camel/pull/21143#issuecomment-3817475175
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #21143:
URL: https://github.com/apache/camel/pull/21143#issuecomment-3817503594
Thanks for helping the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "jvrubel (via GitHub)" <gi...@apache.org>.
jvrubel commented on PR #21143:
URL: https://github.com/apache/camel/pull/21143#issuecomment-3818035873
I will split this PR.
One will contain the changes for customization of the command (along with all the other changes not mentioned below)
Second for the camel-launcher test itself as it will need to be implemented differently in order to eliminate the need of manual upkeep of the link to camel-launcher
Third for the Java upgrade in the container so that we don't have a Java upgrade bundled with a random PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on code in PR #21143:
URL: https://github.com/apache/camel/pull/21143#discussion_r2741544847
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/MavenGradleITCase.java:
##########
@@ -41,11 +42,12 @@ public void runFromGradleTest() throws IOException {
execInContainer(String.format("mkdir %s/gradle-app", mountPoint()));
execInContainer(String.format("cd %s/gradle-app && camel init cheese.xml", mountPoint()));
Review Comment:
@jvrubel I just stumbled on it, the is `camel init` correct here? shouldn't it be `getMainCommand()`?
There may be other issues like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "jvrubel (via GitHub)" <gi...@apache.org>.
jvrubel closed pull request #21143: Rework Camel JBang IT module to enable use of Camel Launcher
URL: https://github.com/apache/camel/pull/21143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework Camel JBang IT module to enable use of Camel Launcher [camel]
Posted by "jvrubel (via GitHub)" <gi...@apache.org>.
jvrubel commented on code in PR #21143:
URL: https://github.com/apache/camel/pull/21143#discussion_r2741666843
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/MavenGradleITCase.java:
##########
@@ -41,11 +42,12 @@ public void runFromGradleTest() throws IOException {
execInContainer(String.format("mkdir %s/gradle-app", mountPoint()));
execInContainer(String.format("cd %s/gradle-app && camel init cheese.xml", mountPoint()));
Review Comment:
Yes, it should, I'll double check everything again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org