[GitHub] [cloudstack-www] nathanmcgarvey commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.

[GitBox <gi...@apache.org>]

nathanmcgarvey commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-845135586


   > > > > 22383 files with over 44000 lines changed in a single commit may hurt repo-wise... if this is merged, ensure that repo packing, garbage collecting, and index-updating is done and maybe a comparison of pre-merge to post-merge size is evaluated. Also, there is _no_ way anybody is reasonably doing a human review on this for real. :)
   > > > > Alternatively, do we really need to be updating the HTML tags for 4.0.0 API documentation from [8?] years ago? Maybe it would be better to just age it off, or put a readme about terminology changes and just change 4.14+ versions. Otherwise, I could see this becoming a repeated effort if other terms are deemed "offensive" in the future. And I'd really rather not start having tens of thousands of changed source code lines be "normal" behavior for a source code repo.
   > > > 
   > > > 
   > > > @nathanmcgarvey Thanks for the review, will remove the relevant changes from the old apidocs.
   > > 
   > > 
   > > @nathanmcgarvey @DaanHoogland Removed the changes in the old api doc references (not relevant now).
   > 
   > @nathanmcgarvey are you LGTM with the changes?
   
   Yep. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org