[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4806: Refactor segments admin rest APIs

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on issue #4806: Refactor segments admin rest APIs
URL: https://github.com/apache/incubator-pinot/pull/4806#issuecomment-552050576
 
 
   @mcvsubbu 
   
   > Did you re-order the methods? I see signatures changed, but marked as deprecated.
   
   Several methods are moved from `PinotSegmentUploadRestletResource` to `PinotSegmentRestletResource`. The current method name does not match the actual semantic of the method, so I changed the method name to match the actual semantic to make them easier to understand.
   
   > (1) Since this is a backward incompatible change (removing some APIs, right?) please be sure to flag it in the commit message so that we can add it correctly in the release notes.
   
   I didn't remove any API, but only mark them deprecated. The only backward incompatible change is that we no longer allow toggling segment state (including drop, drop should be done by DELETE instead of GET)
   
   > (2) Since this is an API change, please open a cwiki page with the proposed new APIs (and changes and deprecations) and let the community comment on it for sometime before merging this change. Be sure to add a link to that page in the commit message.
   
   Will do
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org