You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/23 17:07:26 UTC

[GitHub] [spark] rdblue commented on a change in pull request #28026: [SPARK-31257][SQL] Unify create table syntax

rdblue commented on a change in pull request #28026:
URL: https://github.com/apache/spark/pull/28026#discussion_r511022033



##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -387,8 +376,11 @@ tableProvider
 
 createTableClauses
     :((OPTIONS options=tablePropertyList) |
-     (PARTITIONED BY partitioning=transformList) |
+     (PARTITIONED BY partitioning=partitionFieldList) |

Review comment:
       The result of doing this is a worse error message for a user because the parser would generate an error, instead of the user-friendly error message that is generated by `AstBuilder`. I think an overall worse experience for users isn't worth changing this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org