[GitHub] [mynewt-nimble] michal-narajowski commented on a change in pull request #724: mesh: Fix GATT Proxy behavior to match Mesh Profile Spec 1.0.1

[GitBox <gi...@apache.org>]

michal-narajowski commented on a change in pull request #724: mesh: Fix GATT Proxy behavior to match Mesh Profile Spec 1.0.1
URL: https://github.com/apache/mynewt-nimble/pull/724#discussion_r364237905
 
 

 ##########
 File path: nimble/host/mesh/src/net.c
 ##########
 @@ -1325,13 +1325,19 @@ void bt_mesh_net_recv(struct os_mbuf *data, s8_t rssi,
 	/* Save the state so the buffer can later be relayed */
 	net_buf_simple_save(buf, &state);
 
+	rx.local_match = (bt_mesh_fixed_group_match(rx.ctx.recv_dst) ||
+			  bt_mesh_elem_find(rx.ctx.recv_dst));
+
 	if ((MYNEWT_VAL(BLE_MESH_GATT_PROXY)) &&
 	    net_if == BT_MESH_NET_IF_PROXY) {
 		bt_mesh_proxy_addr_add(data, rx.ctx.addr);
-	}
 
-	rx.local_match = (bt_mesh_fixed_group_match(rx.ctx.recv_dst) ||
-			  bt_mesh_elem_find(rx.ctx.recv_dst));
+		if (bt_mesh_gatt_proxy_get() == BT_MESH_GATT_PROXY_DISABLED &&
 
 Review comment:
   "If the Proxy feature is disabled, a GATT client device can connect
   over GATT to that node for configuration and control. Messages from
   the GATT bearer are not relayed to the advertising bearer."
   
   I'm not 100% sure if this means we should drop messages that are not directed at us or that we just shouldn't relay messages to ADV (see `bt_mesh_net_relay()` call below.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services