You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/03 05:31:15 UTC

[GitHub] [airflow] whynick1 opened a new pull request #8090: Mysql to gcs

whynick1 opened a new pull request #8090: Mysql to gcs
URL: https://github.com/apache/airflow/pull/8090
 
 
   ---
   Issue link: [AIRFLOW-7118](https://issues.apache.org/jira/browse/AIRFLOW-7118)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#issuecomment-611873167
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=h1) Report
   > Merging [#8090](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/94480a731d141df4dd7ed91b4b93952d8e07c5c4&el=desc) will **increase** coverage by `0.40%`.
   > The diff coverage is `92.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/8090/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8090      +/-   ##
   ==========================================
   + Coverage   87.18%   87.58%   +0.40%     
   ==========================================
     Files         937      936       -1     
     Lines       45556    45323     -233     
   ==========================================
   - Hits        39719    39698      -21     
   + Misses       5837     5625     -212     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [...w/providers/google/cloud/operators/mysql\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9teXNxbF90b19nY3MucHk=) | `98.00% <92.85%> (+0.27%)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | ... and [78 more](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=footer). Last update [94480a7...7a87782](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #8090: [AIRFLOW-7118] Honor schema type for MySQL to GCS data pre-process

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #8090: [AIRFLOW-7118] Honor schema type for MySQL to GCS data pre-process
URL: https://github.com/apache/airflow/pull/8090
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] whynick1 commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
whynick1 commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#discussion_r406601342
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/mysql_to_gcs.py
 ##########
 @@ -102,10 +102,12 @@ def field_to_bigquery(self, field):
     def convert_type(self, value, schema_type):
         """
         Takes a value from MySQLdb, and converts it to a value that's safe for
-        JSON/Google Cloud Storage/BigQuery. Dates are converted to UTC seconds.
-        Decimals are converted to floats. Binary type fields are encoded with base64,
-        as imported BYTES data must be base64-encoded according to Bigquery SQL
-        date type documentation: https://cloud.google.com/bigquery/data-types
+        JSON/Google Cloud Storage/BigQuery. Datetimes are converted to UTC seconds.
 
 Review comment:
   Done! Can I get another review please? πŸ˜ƒ @mik-laj 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] whynick1 commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
whynick1 commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#discussion_r406601342
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/mysql_to_gcs.py
 ##########
 @@ -102,10 +102,12 @@ def field_to_bigquery(self, field):
     def convert_type(self, value, schema_type):
         """
         Takes a value from MySQLdb, and converts it to a value that's safe for
-        JSON/Google Cloud Storage/BigQuery. Dates are converted to UTC seconds.
-        Decimals are converted to floats. Binary type fields are encoded with base64,
-        as imported BYTES data must be base64-encoded according to Bigquery SQL
-        date type documentation: https://cloud.google.com/bigquery/data-types
+        JSON/Google Cloud Storage/BigQuery. Datetimes are converted to UTC seconds.
 
 Review comment:
   Done! Can I get another review please? πŸ˜ƒ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#issuecomment-611873167
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=h1) Report
   > Merging [#8090](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/94480a731d141df4dd7ed91b4b93952d8e07c5c4&el=desc) will **increase** coverage by `0.40%`.
   > The diff coverage is `92.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/8090/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8090      +/-   ##
   ==========================================
   + Coverage   87.18%   87.58%   +0.40%     
   ==========================================
     Files         937      936       -1     
     Lines       45556    45323     -233     
   ==========================================
   - Hits        39719    39698      -21     
   + Misses       5837     5625     -212     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [...w/providers/google/cloud/operators/mysql\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9teXNxbF90b19nY3MucHk=) | `98.00% <92.85%> (+0.27%)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | ... and [78 more](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=footer). Last update [94480a7...7a87782](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#discussion_r402751827
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/mysql_to_gcs.py
 ##########
 @@ -102,10 +102,12 @@ def field_to_bigquery(self, field):
     def convert_type(self, value, schema_type):
         """
         Takes a value from MySQLdb, and converts it to a value that's safe for
-        JSON/Google Cloud Storage/BigQuery. Dates are converted to UTC seconds.
-        Decimals are converted to floats. Binary type fields are encoded with base64,
-        as imported BYTES data must be base64-encoded according to Bigquery SQL
-        date type documentation: https://cloud.google.com/bigquery/data-types
+        JSON/Google Cloud Storage/BigQuery. Datetimes are converted to UTC seconds.
 
 Review comment:
   Can you write these conversations as a bulleted list? This will allow us to find a specific case more easily.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] whynick1 commented on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
whynick1 commented on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#issuecomment-608239076
 
 
   Testing locally. Please hold. πŸ˜ƒ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#issuecomment-611873167
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=h1) Report
   > Merging [#8090](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/94480a731d141df4dd7ed91b4b93952d8e07c5c4&el=desc) will **increase** coverage by `0.40%`.
   > The diff coverage is `92.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/8090/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8090      +/-   ##
   ==========================================
   + Coverage   87.18%   87.58%   +0.40%     
   ==========================================
     Files         937      936       -1     
     Lines       45556    45323     -233     
   ==========================================
   - Hits        39719    39698      -21     
   + Misses       5837     5625     -212     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=tree) | Coverage Ξ” | |
   |---|---|---|
   | [...w/providers/google/cloud/operators/mysql\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9teXNxbF90b19nY3MucHk=) | `98.00% <92.85%> (+0.27%)` | :arrow_up: |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
   | ... and [78 more](https://codecov.io/gh/apache/airflow/pull/8090/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Ξ” = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=footer). Last update [94480a7...7a87782](https://codecov.io/gh/apache/airflow/pull/8090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] whynick1 edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
whynick1 edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#issuecomment-608239076
 
 
   Testing locally. Please hold. πŸ˜ƒ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] whynick1 edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

Posted by GitBox <gi...@apache.org>.
whynick1 edited a comment on issue #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#issuecomment-608239076
 
 
   ~~Testing locally. Please hold.~~ πŸ˜ƒ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services