You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2022/08/27 14:49:43 UTC

[kudu] 03/03: [test] instantiate ScanPrivilegeVirtualColumnsTest

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 9021f275824faa2bdfe699786957c40c219697c1
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Fri Aug 26 18:07:33 2022 -0700

    [test] instantiate ScanPrivilegeVirtualColumnsTest
    
    Before this patch, the ScanPrivilegeVirtualColumnsTest suite was not
    instantiated, so no tests from the parameterized suite were run.  This
    patch adds the missing instantiation, so now the tests are run.
    
    This is a follow-up to 66f4bb136e1bc42e8c031548b56ee1927002ac09.
    
    Change-Id: Id60acd02f22a9ed617c590d8cf0387a366ddc0b1
    Reviewed-on: http://gerrit.cloudera.org:8080/18921
    Tested-by: Kudu Jenkins
    Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
 src/kudu/tserver/tablet_server_authorization-test.cc | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/kudu/tserver/tablet_server_authorization-test.cc b/src/kudu/tserver/tablet_server_authorization-test.cc
index ea7fd6a67..69ec62b1a 100644
--- a/src/kudu/tserver/tablet_server_authorization-test.cc
+++ b/src/kudu/tserver/tablet_server_authorization-test.cc
@@ -974,6 +974,15 @@ TEST_P(ScanPrivilegeVirtualColumnsTest, TestNoProjection) {
     NO_FATALS(CheckPrivileges(req_func, scan, privileges, ExpectedAuthz::DENIED));
   }
 }
+INSTANTIATE_TEST_SUITE_P(RequestorFuncs, ScanPrivilegeVirtualColumnsTest,
+                         ::testing::Combine(
+        ::testing::ValuesIn(vector<ScanFunc>({
+            &ScanRequestor<DeprecatedField::DONT_USE, SpecialColumn::VIRTUAL>,
+            &ScanRequestor<DeprecatedField::USE, SpecialColumn::VIRTUAL>,
+            &ChecksumRequestor<DeprecatedField::DONT_USE, SpecialColumn::VIRTUAL>,
+            &ChecksumRequestor<DeprecatedField::USE, SpecialColumn::VIRTUAL>,
+        })),
+        ::testing::Bool()));
 
 class ScanPrivilegeWithBadNamesTest: public ScanPrivilegeAuthzTest {};