You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/11/20 05:42:42 UTC
Re: Review Request 40380: RANGER-733 : Implement best coding
practices to resolve issues found during code scan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40380/
-----------------------------------------------------------
(Updated Nov. 20, 2015, 4:42 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-733
https://issues.apache.org/jira/browse/RANGER-733
Repository: ranger
Description
-------
1. Improved logging in StormClient, KnoxClient, KMSClient and RemoteUnixLoginModule class.
2. Better logging practices implemented for admin activities logs which are stored in x_trx_log table.
3. Changes in Usersync log4j.xml will get picked up after restart.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 4ef3b48
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java f4d5858
plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSClient.java c67584e
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 689e165
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 8fbad1f
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 2d43379
security-admin/src/main/java/org/apache/ranger/json/JsonDateSerializer.java 7493226
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 49f5dde
security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 1c65436
security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 98c987e
security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java 42de408
security-admin/src/main/java/org/apache/ranger/view/VXGroupPermission.java 445b5f0
security-admin/src/main/java/org/apache/ranger/view/VXModuleDef.java 3923d07
security-admin/src/main/java/org/apache/ranger/view/VXUserPermission.java cdbddc5
security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java e992190
security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java e01e23c
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 2b62c4f
unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java 0dd549a
unixauthservice/scripts/ranger-usersync-services.sh ea5c7e8
Diff: https://reviews.apache.org/r/40380/diff/
Testing
-------
Env:
====
OS : Linux
DataBase : MySQL
**Issue-1**: Improve logging in StormClient, KnoxClient, KMSClient and RemoteUnixLoginModule class.
*Steps Performed*: After applying patch changed 'debug=true' in log4j.xml and restarted Ranger then tried test connection from Knox service(knoxdev) page.
*Expected Result*: Test connection config log should come in xa_portal.log file.
*Actual Result*: It was observed that loging was happening according to changes introduced.
*Remark*: Similar steps were performed for logging of Knox and KMS Service test connection event and logs were recorded as expected.
**Issue-2**: Improve logging of admin activities.
*Steps Performed*: After applying patch restarted Ranger then tried to create a user and then tried to update the same user details. Browsed recent record inserted after create/update event in x_trx_log table.
*Expected Result*: x_trx_log table should store the new and old value of the attribute which were changed, also new or old column value should not contains 'null' word for password attribute.
*Actual Result*: It was observed that loging was happening in x_trx_log table according to changes introduced.
**Issue-3**: Changes in Usersync log4j.xml are not get picked up after usersync restart.
*Steps Performed*: After applying patch changed log file name to usersync_new.log and restarted Usersync service. Searched available log files in usersync log home directory(i.e /var/log/ranger/usersync)
*Expected Result*: usersync_new.log file should be created in configured location and logs should come.
*Actual Result*: It was observed that new log file was created and loging was happening in usersync_new.log file.
Thanks,
Gautam Borad
Re: Review Request 40380: RANGER-733 : Implement best coding
practices to resolve issues found during code scan
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40380/#review107356
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Nov. 20, 2015, 4:42 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40380/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 4:42 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-733
> https://issues.apache.org/jira/browse/RANGER-733
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1. Improved logging in StormClient, KnoxClient, KMSClient and RemoteUnixLoginModule class.
> 2. Better logging practices implemented for admin activities logs which are stored in x_trx_log table.
> 3. Changes in Usersync log4j.xml will get picked up after restart.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 4ef3b48
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java f4d5858
> plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSClient.java c67584e
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 689e165
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 8fbad1f
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 2d43379
> security-admin/src/main/java/org/apache/ranger/json/JsonDateSerializer.java 7493226
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 49f5dde
> security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java 1c65436
> security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 98c987e
> security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java 42de408
> security-admin/src/main/java/org/apache/ranger/view/VXGroupPermission.java 445b5f0
> security-admin/src/main/java/org/apache/ranger/view/VXModuleDef.java 3923d07
> security-admin/src/main/java/org/apache/ranger/view/VXUserPermission.java cdbddc5
> security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java e992190
> security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java e01e23c
> storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 2b62c4f
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java 0dd549a
> unixauthservice/scripts/ranger-usersync-services.sh ea5c7e8
>
> Diff: https://reviews.apache.org/r/40380/diff/
>
>
> Testing
> -------
>
> Env:
> ====
>
> OS : Linux
> DataBase : MySQL
>
> **Issue-1**: Improve logging in StormClient, KnoxClient, KMSClient and RemoteUnixLoginModule class.
> *Steps Performed*: After applying patch changed 'debug=true' in log4j.xml and restarted Ranger then tried test connection from Knox service(knoxdev) page.
> *Expected Result*: Test connection config log should come in xa_portal.log file.
> *Actual Result*: It was observed that loging was happening according to changes introduced.
> *Remark*: Similar steps were performed for logging of Knox and KMS Service test connection event and logs were recorded as expected.
>
> **Issue-2**: Improve logging of admin activities.
> *Steps Performed*: After applying patch restarted Ranger then tried to create a user and then tried to update the same user details. Browsed recent record inserted after create/update event in x_trx_log table.
> *Expected Result*: x_trx_log table should store the new and old value of the attribute which were changed, also new or old column value should not contains 'null' word for password attribute.
> *Actual Result*: It was observed that loging was happening in x_trx_log table according to changes introduced.
>
> **Issue-3**: Changes in Usersync log4j.xml are not get picked up after usersync restart.
> *Steps Performed*: After applying patch changed log file name to usersync_new.log and restarted Usersync service. Searched available log files in usersync log home directory(i.e /var/log/ranger/usersync)
> *Expected Result*: usersync_new.log file should be created in configured location and logs should come.
> *Actual Result*: It was observed that new log file was created and loging was happening in usersync_new.log file.
>
>
> Thanks,
>
> Gautam Borad
>
>