You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sonal Ojha <so...@sungardas.com> on 2014/05/08 08:55:06 UTC
[NullPointerException][
Hello,
Related to commit 4b89a45 there is a line change which should have made in
was missed and can lead to exceptions like NullPointerException.
I have raised a another review request https://reviews.apache.org/r/21193/,
please take a look and push it to master if approved.
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability
Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.ojha@sungardas.com ▪
www.sungardas. <http://www.sungardas.com/>*in*
*[image: Logo]* <http://www.sungardas.com/>
*[image: cid:image019.png@01CF48EC.6617C7F0]*
<http://blog.sungardas.com/> *[image:
cid:image020.png@01CF48EC.6617C7F0]* <http://www.youtube.com/user/SunGardAS>
*[image: cid:image021.png@01CF48EC.6617C7F0]*<https://plus.google.com/u/0/102459878242108588663/posts>
*[image: cid:image022.png@01CF48EC.6617C7F0]*<https://www.facebook.com/SunGardAS>
*[image: cid:image023.png@01CF48EC.6617C7F0]*<http://www.linkedin.com/company/sungard-availability-services>
*[image: cid:image024.png@01CF48EC.6617C7F0]*<https://twitter.com/SunGardAS>
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
Re: [NullPointerException][
Posted by Sonal Ojha <so...@sungardas.com>.
Got it, thanks
On Thu, May 8, 2014 at 1:28 PM, Daan Hoogland <da...@gmail.com>wrote:
> never mind, found it.
>
> 2 remarks,
>
> 1. you submitted the first patch as root@devcloud.apache.org. please don't
> @REVIEWERS: please don't let that go in
>
> 2. can you supply the full commit id next time, please? I can shorten
> the long one but can't easily expand the short one.
>
>
> thanks,
> Daan
>
> On Thu, May 8, 2014 at 9:54 AM, Daan Hoogland <da...@gmail.com>
> wrote:
> >
> > On Thu, May 8, 2014 at 8:55 AM, Sonal Ojha <so...@sungardas.com>
> wrote:
> >>
> >> 4b89a45
> >
> >
> > is this patch applied on master only or on 4.4 as well?
> >
> >
> > --
> > Daan
>
>
>
> --
> Daan
>
--
*Thanks and Regards,*
*Sonal Ojha ▪ Sr.Engineer - Product Development **▪ **Sungard Availability
Services, India*
2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowledge Park, Pune - 411 014 ▪
Office: 267-234-9014 ▪ Mobile: +91 9922412645 ▪ sonal.ojha@sungardas.com ▪
www.sungardas. <http://www.sungardas.com/>*in*
*[image: Logo]* <http://www.sungardas.com/>
*[image: cid:image019.png@01CF48EC.6617C7F0]*
<http://blog.sungardas.com/> *[image:
cid:image020.png@01CF48EC.6617C7F0]* <http://www.youtube.com/user/SunGardAS>
*[image: cid:image021.png@01CF48EC.6617C7F0]*<https://plus.google.com/u/0/102459878242108588663/posts>
*[image: cid:image022.png@01CF48EC.6617C7F0]*<https://www.facebook.com/SunGardAS>
*[image: cid:image023.png@01CF48EC.6617C7F0]*<http://www.linkedin.com/company/sungard-availability-services>
*[image: cid:image024.png@01CF48EC.6617C7F0]*<https://twitter.com/SunGardAS>
*CONFIDENTIALITY:* This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.
Re: [NullPointerException][
Posted by Daan Hoogland <da...@gmail.com>.
never mind, found it.
2 remarks,
1. you submitted the first patch as root@devcloud.apache.org. please don't
@REVIEWERS: please don't let that go in
2. can you supply the full commit id next time, please? I can shorten
the long one but can't easily expand the short one.
thanks,
Daan
On Thu, May 8, 2014 at 9:54 AM, Daan Hoogland <da...@gmail.com> wrote:
>
> On Thu, May 8, 2014 at 8:55 AM, Sonal Ojha <so...@sungardas.com> wrote:
>>
>> 4b89a45
>
>
> is this patch applied on master only or on 4.4 as well?
>
>
> --
> Daan
--
Daan
Re: [NullPointerException][
Posted by Daan Hoogland <da...@gmail.com>.
On Thu, May 8, 2014 at 8:55 AM, Sonal Ojha <so...@sungardas.com> wrote:
> 4b89a45
is this patch applied on master only or on 4.4 as well?
--
Daan