You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/31 19:42:00 UTC

[jira] [Commented] (FLINK-7328) Remove Flink's futures from SlotManager

    [ https://issues.apache.org/jira/browse/FLINK-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107844#comment-16107844 ] 

ASF GitHub Bot commented on FLINK-7328:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4443

    [FLINK-7328] [futures] Replace Flink's futures with Java 8's CompletableFuture in SlotManager

    ## What is the purpose of the change
    
    Replace Flink's futures with Java 8's CompletableFuture in SlotManager.
    
    This PR is based on #4438.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink rfSlotManager

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4443
    
----
commit afe1d171132bb3724e672a1c4ce74a3f7c185908
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-07-31T13:07:18Z

    [FLINK-7313] [futures] Add Flink future and Scala future to Java 8 CompletableFuture conversion
    
    Add DirectExecutionContext
    
    Add Scala Future to Java 8 CompletableFuture utility to FutureUtils
    
    Add Flink future to Java 8's CompletableFuture conversion utility to FutureUtils
    
    Add base class for Flink's unchecked future exceptions

commit c265fa386184b1fb940187c7f97c14e1542509de
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-07-31T17:35:14Z

    [FLINK-7324] [futures] Replace Flink's future with Java 8's CompletableFuture in SlotPool

commit 5ff0bfdf9c7e9dc5a6411986eeb7f444763d8249
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-07-31T19:38:28Z

    [FLINK-7328] [futures] Replace Flink's futures with Java 8's CompletableFuture in SlotManager

----


> Remove Flink's futures from SlotManager
> ---------------------------------------
>
>                 Key: FLINK-7328
>                 URL: https://issues.apache.org/jira/browse/FLINK-7328
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> This only affects the internally used Flink futures.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)