You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/04 04:28:59 UTC

[GitHub] [ratis] ChenSammi commented on pull request #699: RATIS-1644. Provide a safe async flush.

ChenSammi commented on PR #699:
URL: https://github.com/apache/ratis/pull/699#issuecomment-1204743602

   > @ChenSammi , thanks for the update! Please see https://issues.apache.org/jira/secure/attachment/13047652/699_review.patch for the review suggestions.
   
   @szetszwo , the difference is it sticks to call updateIncreasingly on flushIndex in your proposal while updateToMax is called currently.  Is there any known side effect of using  updateToMax?  I'm thinking of using PriorityBlockingList in flushExecutor in another PR to improve the performance by executing the raft flush with high commitIndex in priority, and remove all lower commitIndex flush tasks, so that we will have less actual file flush.  In this case, flushIndex will not be update continuously.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org