You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2018/09/12 21:25:00 UTC
[jira] [Created] (RATIS-316) Centralize shaded thirdparty
dependencies in a single artifact
Josh Elser created RATIS-316:
--------------------------------
Summary: Centralize shaded thirdparty dependencies in a single artifact
Key: RATIS-316
URL: https://issues.apache.org/jira/browse/RATIS-316
Project: Ratis
Issue Type: Improvement
Components: build
Reporter: Josh Elser
Assignee: Josh Elser
After the changes in RATIS-288, developers may find that their IDEs are complaining about dependencies that we bundle in ratis-proto-shaded as not being "found".
This is understandable because IDEs typically aren't smart enough to follow the maven-shade-plugin and unravel the relocation that's happening.
The easiest solution for this is to make an artifact for our "thirdparty" dependencies that has its own release schedule. The "core" of Ratis can then depend on this artifact and the relocated dependencies in the well-known location (fix the IDE errors). Additionally, this will give us a bit more flexibility in upgrading to newer versions of these dependencies without having to re-release Ratis (e.g. if there is a CVE on Netty, we can make a new release of ratis-thirdparty without re-releasing Ratis just for that change).
We could move this to a separate git repo, but it's easy enough to just leave this is a sub-directory of ratis.git. I don't have strong feelings either way.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)