You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/21 18:41:14 UTC

[GitHub] [geode] DonalEvans commented on a change in pull request #7290: GEODE-9885: Handle duplicated appends in Redis StringsDUnitTest

DonalEvans commented on a change in pull request #7290:
URL: https://github.com/apache/geode/pull/7290#discussion_r789909586



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisString.java
##########
@@ -469,7 +469,7 @@ public void handleSetExpiration(SetOptions options) {
 
   ////// methods that modify the "value" field ////////////
 
-  protected void valueAppend(byte[] bytes) {
+  protected synchronized void valueAppend(byte[] bytes) {

Review comment:
       Ah, you're right. I'll remove the synchronized from this method and add a synchronized block around that line in `applyReplaceByteArrayAtOffsetDelta()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org