You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@skywalking.apache.org by wu...@apache.org on 2018/06/15 04:21:01 UTC

[incubator-skywalking] branch master updated: Add the Logger modifier "static" in pr #1347 (#1353)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a569dc  Add the Logger modifier "static" in pr #1347 (#1353)
3a569dc is described below

commit 3a569dc20ea3e34fdef8633bdfc568b6bb9febfa
Author: 林嘉琦 Lin Jiaqi <li...@dangdang.com>
AuthorDate: Fri Jun 15 12:20:46 2018 +0800

    Add the Logger modifier "static" in pr #1347 (#1353)
    
    
    * add the Logger modifier "static" in pr
---
 .../apm/collector/client/shardingjdbc/ShardingjdbcClient.java           | 2 +-
 .../storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java b/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java
index 0a2fd3b..3184970 100644
--- a/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java
+++ b/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java
@@ -43,7 +43,7 @@ import io.shardingjdbc.core.api.config.ShardingRuleConfiguration;
  */
 public class ShardingjdbcClient implements Client {
 
-    private final Logger logger = LoggerFactory.getLogger(ShardingjdbcClient.class);
+    private static final Logger logger = LoggerFactory.getLogger(ShardingjdbcClient.class);
     
     private Map<String, ShardingjdbcClientConfig> shardingjdbcClientConfig;
     
diff --git a/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java b/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java
index 716f66c..975a2a8 100644
--- a/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java
+++ b/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java
@@ -36,7 +36,7 @@ import org.slf4j.LoggerFactory;
  */
 public class ShardingjdbcStorageInstaller extends StorageInstaller {
 
-    private final Logger logger = LoggerFactory.getLogger(ShardingjdbcStorageInstaller.class);
+    private static final Logger logger = LoggerFactory.getLogger(ShardingjdbcStorageInstaller.class);
 
     public ShardingjdbcStorageInstaller(boolean isHighPerformanceMode) {
         super(isHighPerformanceMode);

-- 
To stop receiving notification emails like this one, please contact
wusheng@apache.org.