[GitHub] [superset] stephenLYZ commented on a diff in pull request #19310: feat(CRUD): add new empty state

[GitBox <gi...@apache.org>]

stephenLYZ commented on code in PR #19310:
URL: https://github.com/apache/superset/pull/19310#discussion_r847134562


##########
superset-frontend/src/components/EmptyState/index.tsx:
##########
@@ -131,6 +131,11 @@ const ImageContainer = ({ image, size }: ImageContainerProps) => (
   />
 );
 
+const handleMouseDown = (e: SyntheticEvent) => {

Review Comment:
   Actually it is to solve the conflict between blur and click. Currently some of our search filters will trigger the query when blur, since blur will be triggered before click, resulting in click is not work (may also have this problem before). Calling preventDefault after the mousedown trigger will disable the blur so that the click can work properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org