You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <ke...@freestoneinfotech.com> on 2016/05/19 07:34:36 UTC
Review Request 47584: ATLAS-802 : New look UI to show Business Catalog
functionalities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47584/
-----------------------------------------------------------
Review request for atlas, Gautam Borad, Madhan Neethiraj, Selvamohan Neethiraj, and Hemanth Yamijala.
Bugs: ATLAS-802
https://issues.apache.org/jira/browse/ATLAS-802
Repository: atlas
Description
-------
Patch contains following changes :
New design of UI portal with Business Catalog related pages.
Old functionalities work with new UI.
Create and list of Terms in a parent child view.
Diffs
-----
dashboardv2/gruntfile.js e5bcc2f
dashboardv2/package.json 9564566
dashboardv2/public/css/bootstrap-sidebar.css 788466b
dashboardv2/public/css/business-catlog.css 780fa1a
dashboardv2/public/css/fonts/fontawesome-webfont.svg 5603c72
dashboardv2/public/css/fonts/glyphicons-halflings-regular.svg f155876
dashboardv2/public/css/override.css e3ebb10
dashboardv2/public/css/scss/breadcrumb.scss PRE-CREATION
dashboardv2/public/css/scss/business-catlog.scss PRE-CREATION
dashboardv2/public/css/scss/form.scss PRE-CREATION
dashboardv2/public/css/scss/graph.scss PRE-CREATION
dashboardv2/public/css/scss/loader.scss PRE-CREATION
dashboardv2/public/css/scss/login.scss PRE-CREATION
dashboardv2/public/css/scss/main.scss PRE-CREATION
dashboardv2/public/css/scss/nav.scss PRE-CREATION
dashboardv2/public/css/scss/old-style.scss PRE-CREATION
dashboardv2/public/css/scss/override.scss PRE-CREATION
dashboardv2/public/css/scss/panel.scss PRE-CREATION
dashboardv2/public/css/scss/search.scss PRE-CREATION
dashboardv2/public/css/scss/style.scss PRE-CREATION
dashboardv2/public/css/scss/tab.scss PRE-CREATION
dashboardv2/public/css/scss/tag.scss PRE-CREATION
dashboardv2/public/css/scss/theme.scss PRE-CREATION
dashboardv2/public/css/scss/tree.scss PRE-CREATION
dashboardv2/public/css/style.css 40255ad
dashboardv2/public/index.html fc7cfd0
dashboardv2/public/js/collection/BaseCollection.js 909288c
dashboardv2/public/js/collection/VCatalogList.js PRE-CREATION
dashboardv2/public/js/collection/VLineageList.js 4f37f87
dashboardv2/public/js/collection/VSchemaList.js a5bf30c
dashboardv2/public/js/main.js 94d49b7
dashboardv2/public/js/models/VCatalog.js PRE-CREATION
dashboardv2/public/js/models/VSchema.js 24462e6
dashboardv2/public/js/router/Router.js d5a2709
dashboardv2/public/js/templates/asset/AssetPageLayoutView_tmpl.html 7a290d9
dashboardv2/public/js/templates/audit/AuditTableLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/audit/CreateAuditTableLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/BusinessCatalogDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/BusinessCatalogLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/MoveTermLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/SideNavLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/common/aboutAtlas_tmpl.html 9839458
dashboardv2/public/js/templates/common/modal.html c9c545f
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 383bc3e
dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html f67c77d
dashboardv2/public/js/templates/search/SearchDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 70cbf37
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/site/header.html fe3803d
dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/tag/TagDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html cbfbeff
dashboardv2/public/js/templates/tag/TagLayoutView_tmpl.html 160af27
dashboardv2/public/js/templates/tag/addTagAttributeItemView_tmpl.html 9dd62ca
dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 574921a
dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 4682aca
dashboardv2/public/js/utils/CommonViewFunction.js 0ad8504
dashboardv2/public/js/utils/Globals.js d4f25a2
dashboardv2/public/js/utils/Overrides.js 4b96b86
dashboardv2/public/js/utils/Utils.js e942fe3
dashboardv2/public/js/views/asset/AssetPageLayoutView.js ae0ef89
dashboardv2/public/js/views/audit/AuditTableLayoutView.js PRE-CREATION
dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/AddTermLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/MoveTermLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js PRE-CREATION
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js dfa29bb
dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 80cd0ef
dashboardv2/public/js/views/graph/LineageLayoutView.js 8751fbe
dashboardv2/public/js/views/schema/SchemaLayoutView.js 05850ad
dashboardv2/public/js/views/search/SearchDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js 6ada4c7
dashboardv2/public/js/views/search/SearchResultLayoutView.js PRE-CREATION
dashboardv2/public/js/views/site/Header.js dffdf79
dashboardv2/public/js/views/tag/AddTagAttributeView.js PRE-CREATION
dashboardv2/public/js/views/tag/CreateTagLayoutView.js PRE-CREATION
dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/tag/TagDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 76bf842
dashboardv2/public/js/views/tag/TagLayoutView.js 4a40f4a
dashboardv2/public/js/views/tag/addTagAttributeItemView.js c588ba8
dashboardv2/public/js/views/tag/addTagModalView.js 546df22
dashboardv2/public/js/views/tag/createTagsLayoutView.js 95ac2b1
pom.xml 30fb95a
Diff: https://reviews.apache.org/r/47584/diff/
Testing
-------
Verified : Rat check, mvn clean install.
Also verified UI functionities manually.
Note : Need a patch for creating default taxonomy on service start.
Thanks,
keval bhatt
Re: Review Request 47584: ATLAS-802 : New look UI to show Business
Catalog functionalities
Posted by keval bhatt <ke...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47584/
-----------------------------------------------------------
(Updated May 19, 2016, 4:19 p.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Selvamohan Neethiraj, and Hemanth Yamijala.
Changes
-------
Handled following review comments from Hemnth :
**Regressions**
1) Tags column is missing for an asset page. Because of this, any attribute added to a tag is not shown anywhere. - **Done**
2) Hierarchical tags are not asking for parent properties. - **Done**
**New but incomplete functionality**
1) In the Tag page, I cannot delete an attribute, but we show a \u2018x\u2019 icon still. - **Removed x icon**
2) Click on edit button beside asset name. Cancel. Some text is shown \u201cList of all developer languages used by Pivots to build products and control the behaviour of the machine. This list contains every language used since 2008.\u201d - **Done **
3) Publish button doesn\u2019t do anything now. What is it supposed to do? Likewise for comments text and button. - **Done and Removed Publish button where feature is not complete**
Bugs: ATLAS-802
https://issues.apache.org/jira/browse/ATLAS-802
Repository: atlas
Description
-------
Patch contains following changes :
New design of UI portal with Business Catalog related pages.
Old functionalities work with new UI.
Create and list of Terms in a parent child view.
Diffs (updated)
-----
dashboardv2/gruntfile.js e5bcc2f
dashboardv2/package.json 9564566
dashboardv2/public/css/bootstrap-sidebar.css 788466b
dashboardv2/public/css/business-catlog.css 780fa1a
dashboardv2/public/css/fonts/fontawesome-webfont.svg 5603c72
dashboardv2/public/css/fonts/glyphicons-halflings-regular.svg f155876
dashboardv2/public/css/override.css e3ebb10
dashboardv2/public/css/scss/breadcrumb.scss PRE-CREATION
dashboardv2/public/css/scss/business-catlog.scss PRE-CREATION
dashboardv2/public/css/scss/form.scss PRE-CREATION
dashboardv2/public/css/scss/graph.scss PRE-CREATION
dashboardv2/public/css/scss/loader.scss PRE-CREATION
dashboardv2/public/css/scss/login.scss PRE-CREATION
dashboardv2/public/css/scss/main.scss PRE-CREATION
dashboardv2/public/css/scss/nav.scss PRE-CREATION
dashboardv2/public/css/scss/old-style.scss PRE-CREATION
dashboardv2/public/css/scss/override.scss PRE-CREATION
dashboardv2/public/css/scss/panel.scss PRE-CREATION
dashboardv2/public/css/scss/search.scss PRE-CREATION
dashboardv2/public/css/scss/style.scss PRE-CREATION
dashboardv2/public/css/scss/tab.scss PRE-CREATION
dashboardv2/public/css/scss/tag.scss PRE-CREATION
dashboardv2/public/css/scss/theme.scss PRE-CREATION
dashboardv2/public/css/scss/tree.scss PRE-CREATION
dashboardv2/public/css/style.css 40255ad
dashboardv2/public/index.html fc7cfd0
dashboardv2/public/js/collection/BaseCollection.js 909288c
dashboardv2/public/js/collection/VCatalogList.js PRE-CREATION
dashboardv2/public/js/collection/VLineageList.js 4f37f87
dashboardv2/public/js/collection/VSchemaList.js a5bf30c
dashboardv2/public/js/main.js 94d49b7
dashboardv2/public/js/models/VCatalog.js PRE-CREATION
dashboardv2/public/js/models/VSchema.js 24462e6
dashboardv2/public/js/modules/atlasLogin.js PRE-CREATION
dashboardv2/public/js/router/Router.js d5a2709
dashboardv2/public/js/templates/asset/AssetPageLayoutView_tmpl.html 7a290d9
dashboardv2/public/js/templates/audit/AuditTableLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/audit/CreateAuditTableLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/BusinessCatalogDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/BusinessCatalogLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/MoveTermLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/SideNavLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/common/aboutAtlas_tmpl.html 9839458
dashboardv2/public/js/templates/common/modal.html c9c545f
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 383bc3e
dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html f67c77d
dashboardv2/public/js/templates/search/SearchDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 70cbf37
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/site/header.html fe3803d
dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/tag/TagDetailLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html cbfbeff
dashboardv2/public/js/templates/tag/TagLayoutView_tmpl.html 160af27
dashboardv2/public/js/templates/tag/addTagAttributeItemView_tmpl.html 9dd62ca
dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 574921a
dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 4682aca
dashboardv2/public/js/utils/CommonViewFunction.js 0ad8504
dashboardv2/public/js/utils/Globals.js d4f25a2
dashboardv2/public/js/utils/Overrides.js 4b96b86
dashboardv2/public/js/utils/Utils.js e942fe3
dashboardv2/public/js/views/asset/AssetPageLayoutView.js ae0ef89
dashboardv2/public/js/views/audit/AuditTableLayoutView.js PRE-CREATION
dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/AddTermLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/MoveTermLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js PRE-CREATION
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js dfa29bb
dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 80cd0ef
dashboardv2/public/js/views/graph/LineageLayoutView.js 8751fbe
dashboardv2/public/js/views/schema/SchemaLayoutView.js 05850ad
dashboardv2/public/js/views/search/SearchDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js 6ada4c7
dashboardv2/public/js/views/search/SearchResultLayoutView.js PRE-CREATION
dashboardv2/public/js/views/site/Header.js dffdf79
dashboardv2/public/js/views/tag/AddTagAttributeView.js PRE-CREATION
dashboardv2/public/js/views/tag/CreateTagLayoutView.js PRE-CREATION
dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/tag/TagDetailLayoutView.js PRE-CREATION
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 76bf842
dashboardv2/public/js/views/tag/TagLayoutView.js 4a40f4a
dashboardv2/public/js/views/tag/addTagAttributeItemView.js c588ba8
dashboardv2/public/js/views/tag/addTagModalView.js 546df22
dashboardv2/public/js/views/tag/createTagsLayoutView.js 95ac2b1
pom.xml 30fb95a
Diff: https://reviews.apache.org/r/47584/diff/
Testing
-------
Verified : Rat check, mvn clean install.
Also verified UI functionities manually.
Note : Need a patch for creating default taxonomy on service start.
Thanks,
keval bhatt