You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/18 14:06:54 UTC
[GitHub] [airflow] char101 opened a new issue #20396: Separate dag id with dag name
char101 opened a new issue #20396:
URL: https://github.com/apache/airflow/issues/20396
### Description
**Problem**
It is not easy to rename dags.
**Suggestion**
It would be better if dag can have both id and name. Id could be some guid/uuid. If not given then id can be generated. At least when required the id can be queried from the database. This way we can change the dag name without changing the id.
```python
DAG_ID = '76c9eb30-4f9c-4806-aad8-931c03679726'
DAG_NAME = 'test'
with DAG(dag_id=DAG_ID, dag_name=DAG_NAME, ...):
# some tasks
```
If I want to rename the dag then I can simply change the name and I can still get the dag history and not running into the risk of backfilling the dag again.
```python
DAG_ID = '76c9eb30-4f9c-4806-aad8-931c03679726'
DAG_NAME = 'test_edited'
with DAG(dag_id=DAG_ID, dag_name=DAG_NAME, ...):
# some tasks
```
### Use case/motivation
So that dag can be easily renamed.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes it causes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change". And none of us have ready answers for those.
IMHO - It is not cosmetic change. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think abou it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997207463
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] char101 commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
char101 commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997216860
DAG already have id. so we just need a name field. Adding name field is basically cosmetic and can be implemented with less risk:
* add name field to the table
* add name parameter to the constructor
* incrementally fix the templates to use dag name instead of id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997226504
> All in all I think this is a separate problem and should not be viewed from the versioning point of view.
Yep. That's your opinion looking from short term gain point of view. Mine is simply different when i look at it from product point of view. We just have different opinions :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] char101 commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
char101 commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997226083
> You also need to update APIs for example to retrieve it
At least adding a name field won't break the APIs. So changes can be implemented incrementally.
> ID will (likely) change it's meaning of being name
Why should id be changed into name? Just keep it that way but add an optional name parameter. This way backward compatibility can be maintained.
> you have duplicate names
Should not be a problem just like two person can have the same name.
> Should you be able to search by it
Of course.
> Should you be able to query by both id and name when hafl of your dags have names and the other does not?
Name should be coalesced to id to maintain backward compatibility.
> What should it look like in the UI when different name was used in the past and changed?
This is versioning problem. What I am suggesting is the problem with the current airflow which does not have versioning. Past names should only appear in a history menu.
> Should we keep the history of those names?
This is the problem of versioning.
All in all I think this is a separate problem and should not be viewed from the versioning point of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes it causes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change". And none of us have ready answers for those.
IMHO - It is not cosmetic change. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think about it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997214363
I think it shoudl be part of the bigger discussion on DAG versioning AIP: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-36+DAG+Versioning. Separating name from id and being able to version a file are - in my view - inseparable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes it causes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change".
IMHO - It is not. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think abou it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #20396: Add separate name attribut for dag so that dag can be easily renamed
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-1012995249
Since this is AIP-36 related. i suggest to take it to the AIP comment page / relevant thread in the mailing list... We usualy dont discuss AIPs in github issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997214363
I think it shoudl be part of the bigger discussion on DAG versioning AIP: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-36+DAG+Versioning. Separating name from id and being able to version a DAG are - in my view - inseparable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] char101 commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
char101 commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997227787
I have the right to have my own opinion whether it is right or wrong. I am not pushing my opinion to you. Expressing my opinion does not prevent others from expressing their opinions.
Also it is clear that you are viewing this from the point of view of a product manager. I am viewing this from the point of view of a user that just want to get things done. You probably should not expect for users to think like a product manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997227101
I am just a little surprised you have such clarity and know all the answers. I am developing the product for ~3 years and I would not even dare to answer those without trying to understand what are deeper consequences and future vision of the product and listening to other's opinion.
I really did not expect from you immediate answers and wanted to hear what others think about it. Just wanted to post the areas that others should consider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997228507
I don't deny your right to have an opinion. Nowhere in this discussion actually. I just try to hear (from three posts what others think).Your "defensive" approach make it very difficult for others to express their opinion here. You are risking that others won't chime in here because they will think we are arguing with each other. Just my 2 cents and suggestion to wait to hear what other others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] char101 edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
char101 edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997216860
DAG already have id, so we just need a name field. Adding name field is basically cosmetic and can be implemented with less risk:
* add name field to the table
* add an optional name parameter to the constructor
* incrementally fix the templates to use coalesce(name, id) instead of id
Maybe the relation to versioning is that name and tags are attributes that could be versioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #20396: Add separate name attribut for dag so that dag can be easily renamed
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #20396:
URL: https://github.com/apache/airflow/issues/20396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes it causes. Should you be able to query tasks by name? Should you be able to search by it? Should you be able to query by both id and name when hafl of your dags have names and the other does not? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change". And none of us have ready answers for those.
IMHO - It is not cosmetic change. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think about it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes it causes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change". And none of us have ready answer for those.
IMHO - It is not. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think abou it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997227101
I am just a little surprised you have such clarity and know all the answers. I am developing the product for ~3 years and I would not even dear to answer those without trying to understand what you consider deeper consequences and future vision of the product and listening to other's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997227101
I am just a little surprised you have such clarity and know all the answers. I am developing the product for ~3 years and I would not even dare to answer those without trying to understand what are deeper consequences and future vision of the product and listening to other's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997228507
I don't deny your right to have an opinion. Nowhere in this discussion actually. I just try to hear (from three posts ago) what others think.Your "defensive" approach make it very difficult for others to express their opinion here. You are risking that others won't chime in here because they will think we are arguing with each other. Just my 2 cents and suggestion to wait to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first 12 questions that pop in my head when you say "this is a cosmetic change".
IMHO - It is not. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think abou it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997227101
I am just a little surprised you have such clarity and know all the answers. I am developing the product for ~3 years and I would not even dare to answer those without trying to understand what you consider deeper consequences and future vision of the product and listening to other's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] char101 edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
char101 edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997216860
DAG already have id, so we just need a name field. Adding name field is basically cosmetic and can be implemented with less risk:
* add name field to the table
* add name parameter to the constructor
* incrementally fix the templates to use dag name instead of id
Maybe the relation to versioning is that name and tags are attributes that could be versioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997228507
I don't deny your right to have an opinion. Nowhere in this discussion actually. I just try to hear (from three posts what others think).Your "defensive" approach make it very difficult for others to express their opinion here. You are risking that others won't chime in here because they will think we are arguing with each other. Just my 2 cents and suggestion to wait to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997228507
I don't deny your right to have an opinion. Nowhere in this discussion actually. I just try to hear (from three posts what others think).Your "defensive" approach make it very difficult for others to express their opinion here. You are risking that others won't chime in here because they will think we are arguing with each other. Just my 2 cents and suggestion to wait what other think before others chime in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change".
IMHO - It is not. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think abou it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #20396: Separate dag id with dag name
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20396:
URL: https://github.com/apache/airflow/issues/20396#issuecomment-997223244
It's more than that. You also need to update APIs for example to retrieve it and define what kind of relation it will have in the future when we have dag versioning and ID will (likely) change it's meaning of being name. And you need to define how it behaves when you have duplicate names (can you?) and define what to do if some of your dags have name and some of them not, and probably a number of changes it causes. Should you be able to query tasks by name? Should you be able to search by it? What should it look like in the UI when different name was used in the past and changed? Should we keep the history of those names?
Those are just first few questions that pop in my head when you say "this is a cosmetic change". And none of us have ready answers for those.
IMHO - It is not. And we need to introduce such changes only when we know how it fits in the bigger vision of dag versioning. But that's my opinion only so I wonder what others think abou it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org