You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/09 15:58:43 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
brbzull0 opened a new pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659
During my last change around the removal of the explicit and unnecessary use of the runroot flag when calling `traffic_ctl` inside a unit test I missed this one file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659#issuecomment-1033934078
[approve ci Clang-Format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659#discussion_r802826366
##########
File path: tests/gold_tests/pluginTest/remap_stats/remap_stats.test.py
##########
@@ -64,7 +64,7 @@
# 2 Test - Gather output
tr = Test.AddTestRun("analyze stats")
-tr.Processes.Default.Command = r'traffic_ctl metric match \.\*remap_stats\* {0}'.format(ts.Disk.runroot_yaml.Name)
+tr.Processes.Default.Command = r'traffic_ctl metric match \.\*remap_stats\*'
Review comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659#issuecomment-1034763145
It seems that after the merge from master into 10-Dev this change is no longer needed. Closing this PR.
Change comes from [here](https://github.com/apache/trafficserver/commit/0e59150cce09ff1bb1e9714fa7238db2e0f1c475#diff-e6981ca79d580089dd65de5b4a5b6103383053393190dc4311e510458f074aebR68)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 closed pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
Posted by GitBox <gi...@apache.org>.
brbzull0 closed pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 removed a comment on pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
Posted by GitBox <gi...@apache.org>.
brbzull0 removed a comment on pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659#issuecomment-1033934078
[approve ci Clang-Format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8659: Remove the unnecessary runroot flag from traffic_ctl cmd in a unit test.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8659:
URL: https://github.com/apache/trafficserver/pull/8659#issuecomment-1033935740
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org