You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/07/19 14:23:00 UTC

[jira] [Created] (ARROW-5991) [C++] Does DictionaryBuilder need to be a subclass of ArrayBuilder?

Wes McKinney created ARROW-5991:
-----------------------------------

             Summary: [C++] Does DictionaryBuilder<T> need to be a subclass of ArrayBuilder? 
                 Key: ARROW-5991
                 URL: https://issues.apache.org/jira/browse/ARROW-5991
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Wes McKinney


I note that {{DictionaryBuilder<T>}} is book-keeping properties both in {{values_builder_}} as well as itself, such as {{length_}} and {{null_count_}}. 

There are two possibilities:

* DictionaryBuilder need not be a subclass of ArrayBuilder
* A common abstract base for builders could be defined to allow properties like {{length_}} to be forwarded by virtual overrides



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)