You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Dan Adams (JIRA)" <ji...@apache.org> on 2010/08/11 00:19:16 UTC
[jira] Created: (TAP5-1241) Automatic gzipping does not allow
setting a content length for generated content
Automatic gzipping does not allow setting a content length for generated content
--------------------------------------------------------------------------------
Key: TAP5-1241
URL: https://issues.apache.org/jira/browse/TAP5-1241
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.4
Reporter: Dan Adams
If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
The workaround at the moment is simply not setting a content length.
This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1241.
--------------------------------------
Fix Version/s: 5.2.1
Resolution: Fixed
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.1
>
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1241.
--------------------------------------
Fix Version/s: 5.2.1
Resolution: Fixed
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.1
>
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904721#action_12904721 ]
Hudson commented on TAP5-1241:
------------------------------
Integrated in tapestry-5.2-freestyle #183 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/183/])
TAP5-1241: Setting the content length of the response should automatically disable response compression
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.1
>
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1241) Automatic gzipping does not allow
setting a content length for generated content
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904688#action_12904688 ]
Howard M. Lewis Ship commented on TAP5-1241:
--------------------------------------------
I'm not really sure how to address this, beyond TAP5-1236 which allows your code to disable compression easier. In the existing code base, the only code that invokes setContentLength() is related to assets (and virtual JavaScript assets) and always does a disableCompression() (and sets the content length to the right length, regardless of whether using compression or not).
Perhaps setting a content length should disable compression automatically?
> Automatic gzipping does not allow setting a content length for generated content
> --------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904721#action_12904721 ]
Hudson commented on TAP5-1241:
------------------------------
Integrated in tapestry-5.2-freestyle #183 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/183/])
TAP5-1241: Setting the content length of the response should automatically disable response compression
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.1
>
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1241:
---------------------------------------
Summary: Setting the content length of the response should automatically disable response compression (was: Automatic gzipping does not allow setting a content length for generated content)
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1241:
---------------------------------------
Summary: Setting the content length of the response should automatically disable response compression (was: Automatic gzipping does not allow setting a content length for generated content)
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1241) Automatic gzipping does not allow
setting a content length for generated content
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1241:
------------------------------------------
Assignee: Howard M. Lewis Ship
> Automatic gzipping does not allow setting a content length for generated content
> --------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1241) Automatic gzipping does not allow
setting a content length for generated content
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1241:
------------------------------------------
Assignee: Howard M. Lewis Ship
> Automatic gzipping does not allow setting a content length for generated content
> --------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904705#action_12904705 ]
Howard M. Lewis Ship commented on TAP5-1241:
--------------------------------------------
Ok, decided to go that route.
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1241) Automatic gzipping does not allow
setting a content length for generated content
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904688#action_12904688 ]
Howard M. Lewis Ship commented on TAP5-1241:
--------------------------------------------
I'm not really sure how to address this, beyond TAP5-1236 which allows your code to disable compression easier. In the existing code base, the only code that invokes setContentLength() is related to assets (and virtual JavaScript assets) and always does a disableCompression() (and sets the content length to the right length, regardless of whether using compression or not).
Perhaps setting a content length should disable compression automatically?
> Automatic gzipping does not allow setting a content length for generated content
> --------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1241) Setting the content length of the
response should automatically disable response compression
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904705#action_12904705 ]
Howard M. Lewis Ship commented on TAP5-1241:
--------------------------------------------
Ok, decided to go that route.
> Setting the content length of the response should automatically disable response compression
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-1241
> URL: https://issues.apache.org/jira/browse/TAP5-1241
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Dan Adams
> Assignee: Howard M. Lewis Ship
>
> If if you have Dispatcher (or something else) that generates a response and call response.setContentLength() on a text/* mime type the resulting response content length does not match the length of the actual response. This is due to that you set the content length for the uncompressed content and the response is intercepted and gzipped but the original length is still set. In firefox and IE this doesn't appear to be a problem. Chrome however will simply not load stylesheets where this occurs.
> If something like GZipFilter is going to automatically gzip the response it should also change the content length to reflect the new response length.
> The workaround at the moment is simply not setting a content length.
> This may very well effect future versions; I couldn't find an existing ticket though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.