Re: [PR] Add Polaris Events to Persistence [polaris]

["adnanhemani (via GitHub)" <gi...@apache.org>]

adnanhemani commented on PR #1844:
URL: https://github.com/apache/polaris/pull/1844#issuecomment-3021932872

   Based on our discussion at the latest Polaris Community sync, please take a look at the new implementation. A variety of changes were made based on the suggestions:
   * File Buffer was removed
   * Re-did configuration reading
   * Changed all events back to Java `record`. This comes with the overhead of needing to create the Event ID manually - and passing in applicable contexts to the Event Listeners directly.
       * Having the PolarisCallContext helps ensure we can always get the time for the event using the Java Clock.
       * Added EventId to all events as well.
   * Implemented a request ID in the `PolarisCallContext`. This will allow us to efficiently (and correctly) determine the request ID for any generated event.
   * Implemented JDBC Batch Inserts rather than using a single SQL statement
   
   cc @adutra @snazy 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org