You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "emilk (via GitHub)" <gi...@apache.org> on 2026/09/08 14:29:35 UTC
[PR] Enable more clippy lints (part 2/3) [datafusion]
emilk opened a new pull request, #25080:
URL: https://github.com/apache/datafusion/pull/25080
## Which issue does this PR close?
- Part of #18467.
## Rationale for this change
Part 2 of 3, split out of #24848. Stacked on part 1, so review that first:
- PR1LINK
- PR3LINK
Turn on more `clippy::pedantic` lints from the opt-out list in `Cargo.toml`.
## What changes are included in this PR?
One commit per lint, each removing its `"allow"` line from `Cargo.toml` and
fixing every site. Review one commit at a time!
Let me know if you disagree with any and I'll revert it.
| Lint | Sites | Fix |
| ------------------------------------------------------------------------------------------------------------- | ----: | ------------------------------------------------------------------ |
| [`unnested_or_patterns`](https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns) | 68 | `Time32(Microsecond \| Nanosecond)` instead of repeating the prefix |
| [`match_bool`](https://rust-lang.github.io/rust-clippy/master/index.html#match_bool) | 46 | `if`/`else` instead of `match` on a bool |
| [`missing_fields_in_debug`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug) | 29 | `finish_non_exhaustive()` on manual `Debug` impls that skip a field |
## What is the testing strategy for this PR?
Clippy is clean both with `--all-features` and with default features. The
changes are mechanical, so no new tests.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Enable more clippy lints (part 2/3) [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25080:
URL: https://github.com/apache/datafusion/pull/25080#issuecomment-5590129176
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25080?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `83.46582%` with `104 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.74%. Comparing base ([`a5c809f`](https://app.codecov.io/gh/apache/datafusion/commit/a5c809f98dedcf4b22f5d317ea8efe0720834925?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6599716`](https://app.codecov.io/gh/apache/datafusion/commit/6599716a6e40194a562e609d3861ae06bdde5492?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/25080?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/datasource/src/write/orchestration.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fdatasource%2Fsrc%2Fwrite%2Forchestration.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9kYXRhc291cmNlL3NyYy93cml0ZS9vcmNoZXN0cmF0aW9uLnJz) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/expr/src/type\_coercion/functions.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fexpr%2Fsrc%2Ftype_coercion%2Ffunctions.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy90eXBlX2NvZXJjaW9uL2Z1bmN0aW9ucy5ycw==) | 54.54% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/sql/src/select.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fsql%2Fsrc%2Fselect.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3NlbGVjdC5ycw==) | 85.71% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/common/src/scalar/mod.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fcommon%2Fsrc%2Fscalar%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3NjYWxhci9tb2QucnM=) | 63.63% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/datasource-parquet/src/sink.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fdatasource-parquet%2Fsrc%2Fsink.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9kYXRhc291cmNlLXBhcnF1ZXQvc3JjL3NpbmsucnM=) | 86.66% | [2 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [benchmarks/src/sql\_benchmark.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=benchmarks%2Fsrc%2Fsql_benchmark.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YmVuY2htYXJrcy9zcmMvc3FsX2JlbmNobWFyay5ycw==) | 86.95% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/common/src/stats.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fcommon%2Fsrc%2Fstats.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3N0YXRzLnJz) | 86.36% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/execution/src/async\_stream.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fexecution%2Fsrc%2Fasync_stream.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9leGVjdXRpb24vc3JjL2FzeW5jX3N0cmVhbS5ycw==) | 40.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [datafusion/functions/src/datetime/to\_time.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Ffunctions%2Fsrc%2Fdatetime%2Fto_time.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9mdW5jdGlvbnMvc3JjL2RhdGV0aW1lL3RvX3RpbWUucnM=) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...usion/physical-plan/src/operator\_statistics/mod.rs](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&filepath=datafusion%2Fphysical-plan%2Fsrc%2Foperator_statistics%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1wbGFuL3NyYy9vcGVyYXRvcl9zdGF0aXN0aWNzL21vZC5ycw==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [47 more](https://app.codecov.io/gh/apache/datafusion/pull/25080?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25080 +/- ##
==========================================
- Coverage 81.74% 81.74% -0.01%
==========================================
Files 1128 1128
Lines 416644 416631 -13
Branches 416644 416631 -13
==========================================
- Hits 340592 340576 -16
- Misses 55995 56006 +11
+ Partials 20057 20049 -8
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25080?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org