You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2026/05/06 03:12:42 UTC

(spark) branch branch-4.2 updated: [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md

This is an automated email from the ASF dual-hosted git repository.

cloud-fan pushed a commit to branch branch-4.2
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.2 by this push:
     new 3d3df32230e8 [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md
3d3df32230e8 is described below

commit 3d3df32230e8d485f47d52fb09d72a7270370591
Author: Wenchen Fan <we...@databricks.com>
AuthorDate: Wed May 6 11:11:58 2026 +0800

    [MINOR][DOCS] Clarify when to ask the user before running tests in AGENTS.md
    
    ### What changes were proposed in this pull request?
    
    Tighten the wording in `AGENTS.md` that tells coding agents to ask the user about pending changes before running tests. The previous wording fired even when the user explicitly asked for a test run.
    
    Before:
    > Build and tests can take a long time. Before running tests, ask the user if they have more changes to make.
    
    After:
    > Build and tests can take a long time. If the user explicitly asked to run tests, run them. Otherwise (you are running tests on your own to verify a change), first ask the user if they have more changes to make.
    
    ### Why are the changes needed?
    
    The intent of the original instruction was to avoid kicking off a long, agent-initiated test run when the user has more edits coming. But as written, it also applies when the user explicitly requests a test run, which makes the prompt redundant and annoying. Spelling out both branches makes it easier for LLMs to follow the rule correctly.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No. Documentation-only update for coding agent instructions.
    
    ### How was this patch tested?
    
    N/A — documentation only.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Claude Opus 4.7)
    
    Closes #55685 from cloud-fan/minor-agents-md-test-prompt.
    
    Authored-by: Wenchen Fan <we...@databricks.com>
    Signed-off-by: Wenchen Fan <we...@databricks.com>
    (cherry picked from commit feab9257f7961a554023628f9d3ed06685619e80)
    Signed-off-by: Wenchen Fan <we...@databricks.com>
---
 AGENTS.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/AGENTS.md b/AGENTS.md
index 28272d19fe93..96f5b7917cae 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -22,7 +22,7 @@ Avoid introducing non-ASCII characters in code or comments. String literals may
 
 ## Build and Test
 
-Build and tests can take a long time. Before running tests, ask the user if they have more changes to make.
+Build and tests can take a long time. If the user explicitly asked to run tests, run them. Otherwise (you are running tests on your own to verify a change), first ask the user if they have more changes to make.
 
 Prefer SBT over Maven for faster incremental compilation. Module names are defined in `project/SparkBuild.scala`.
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org