You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/14 15:59:02 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7097: arch/arm: unify compile flags to common/Toolchain.defs
anchao opened a new pull request, #7097:
URL: https://github.com/apache/incubator-nuttx/pull/7097
## Summary
arch/arm: unify compile flags to common/Toolchain.defs
## Impact
N/A
## Testing
ci-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7097: arch/arm: unify compile flags to common/Toolchain.defs
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7097:
URL: https://github.com/apache/incubator-nuttx/pull/7097#discussion_r971920910
##########
arch/arm/Kconfig:
##########
@@ -6,6 +6,44 @@
if ARCH_ARM
comment "ARM Options"
+choice
+ prompt "Toolchain Selection"
+ default TOOLCHAIN_GNU_EABI
+
+config TOOLCHAIN_IAR
Review Comment:
Done
##########
Kconfig:
##########
@@ -1980,7 +1980,7 @@ config DEBUG_OPTLEVEL
config DEBUG_OPT_UNUSED_SECTIONS
bool "Optimization to eliminate the unused input sections"
default y
- depends on ARCH_TOOLCHAIN_GNU
+ depends on TOOLCHAIN_IS_GNU
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7097: arch/arm: unify compile flags to common/Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7097:
URL: https://github.com/apache/incubator-nuttx/pull/7097#issuecomment-1248434658
https://github.com/apache/incubator-nuttx/pull/7100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #7097: arch/arm: unify compile flags to common/Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #7097: arch/arm: unify compile flags to common/Toolchain.defs
URL: https://github.com/apache/incubator-nuttx/pull/7097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7097: arch/arm: unify compile flags to common/Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7097:
URL: https://github.com/apache/incubator-nuttx/pull/7097#discussion_r971719487
##########
arch/arm/Kconfig:
##########
@@ -6,6 +6,44 @@
if ARCH_ARM
comment "ARM Options"
+choice
+ prompt "Toolchain Selection"
+ default TOOLCHAIN_GNU_EABI
+
+config TOOLCHAIN_IAR
Review Comment:
add ARM_
##########
Kconfig:
##########
@@ -1980,7 +1980,7 @@ config DEBUG_OPTLEVEL
config DEBUG_OPT_UNUSED_SECTIONS
bool "Optimization to eliminate the unused input sections"
default y
- depends on ARCH_TOOLCHAIN_GNU
+ depends on TOOLCHAIN_IS_GNU
Review Comment:
should we keep ARCH_ prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org