You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/01 02:20:29 UTC

[GitHub] [tvm] comaniac commented on pull request #10122: [CUDA] Support float16 erf,tan,atan

comaniac commented on pull request #10122:
URL: https://github.com/apache/tvm/pull/10122#issuecomment-1026416660


   > Overall it looks good. Given it’s a change for codegen from the low-level IR, would you like to use TVMScript to write some more direct unittests instead? Thanks a lot!
   
   Since the change is within CUDA intrinsics which won't affect any existing cases, and they are basically just mapped to TIR nodes, I suppose the current unit tests are sufficient (as long as they work as expected lol)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org