You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/23 17:27:55 UTC
[GitHub] [incubator-mxnet] zachgk commented on a change in pull request
#14778: Updates python setup.py for recent license changes
zachgk commented on a change in pull request #14778: Updates python setup.py for recent license changes
URL: https://github.com/apache/incubator-mxnet/pull/14778#discussion_r277788374
##########
File path: tools/pip/setup.py
##########
@@ -66,12 +66,8 @@ def has_ext_modules(self):
shutil.copy(LIB_PATH[0], os.path.join(CURRENT_DIR, 'mxnet'))
# copy license and notice
-shutil.copy(os.path.join(CURRENT_DIR, 'mxnet-build/LICENSE'),
- os.path.join(CURRENT_DIR, 'mxnet/LICENSE'))
-shutil.copy(os.path.join(CURRENT_DIR, 'mxnet-build/DISCLAIMER'),
Review comment:
We do not currently add this DISCLAIMER. Can you add it to the build similarly to https://github.com/apache/incubator-mxnet/pull/14726/files#diff-2c9b07f53d24caa1ac38f1eb9c371118R70?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services