You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Manoj Govindassamy (JIRA)" <ji...@apache.org> on 2016/10/13 21:45:21 UTC
[jira] [Created] (HADOOP-13721) Remove stale method
ViewFileSystem#getTrashCanLocation
Manoj Govindassamy created HADOOP-13721:
-------------------------------------------
Summary: Remove stale method ViewFileSystem#getTrashCanLocation
Key: HADOOP-13721
URL: https://issues.apache.org/jira/browse/HADOOP-13721
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.0.0-alpha2
Reporter: Manoj Govindassamy
Assignee: Manoj Govindassamy
Priority: Minor
{{ViewFileSystem}} which extends {{FileSystem}} has a public method {{getTrashCanLocation}} which is neither overridden nor used by anybody. Looks like it existed when the file was created, and also I see the implementation returning homeDirectory which might not be the expected one in cases of {{expunge}}. So, inclined to remove this stale and potentially dangerous method unless anyone has any concerns.
{code}
public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
final InodeTree.ResolveResult<FileSystem> res =
fsState.resolve(getUriPath(f), true);
return res.isInternalDir() ? null : res.targetFileSystem.getHomeDirectory();
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org