[GitHub] [airflow] houqp commented on a change in pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var
URL: https://github.com/apache/airflow/pull/5668#discussion_r315030889
 
 

 ##########
 File path: tests/operators/test_email_operator.py
 ##########
 @@ -57,6 +57,6 @@ def _run_as_operator(self, **kwargs):
         task.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE)
 
     def test_execute(self):
-        with conf_vars({('email', 'EMAIL_BACKEND'): 'tests.operators.test_email_operator.send_email_test'}):
+        with conf_vars({('email', 'email_backend'): 'tests.operators.test_email_operator.send_email_test'}):
 
 Review comment:
   That's correct, we have explicit `lower` method call on both key and section in the `get` method. Only `as_dict` returns case sensitive keys and sections. I added an extra test case as proof.
   
   It is not consistent right now, do we want to make `get` case sensitive as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services