You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 14:42:12 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #11393: [WIP] chore(chart-data): add annotations to chart data schema

villebro opened a new pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393


   ### SUMMARY
   Add support for annotations to chart API schemas.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #11393: [WIP] chore(chart-data): add annotations to chart data schema

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#discussion_r512531097



##########
File path: superset/charts/schemas.py
##########
@@ -817,6 +900,19 @@ class ChartDataQueryObjectSchema(Schema):
         "as `having_druid`.",
         deprecated=True,
     )
+    druid_time_origin = fields.String(
+        description="Starting point for time grain counting on legacy Druid "
+        "datasources. Used to change e.g. Monday/Sunday first-day-of-week. "
+        "This field is deprecated and should be passed to `extras` "
+        "as `druid_time_origin`.",
+        allow_none=True,
+    )
+    url_params = fields.Dict(
+        description="Optional query parameters passed to a dashboard or Explore view",
+        keys=fields.String(description="The query parameter"),
+        values=fields.String(description="The value of the query parameter"),
+        allow_none=True,
+    )

Review comment:
       Bycatch: this was missing, will be added to `superset-ui/core`, after which url params can be used in v1 chart data requests with jinja templates.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **decrease** coverage by `0.99%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   - Coverage   62.26%   61.26%   -1.00%     
   ==========================================
     Files         863      417     -446     
     Lines       40978    25989   -14989     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25516    15923    -9593     
   + Misses      15283    10066    -5217     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.26% <100.00%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   - Coverage   62.26%   62.21%   -0.06%     
   ==========================================
     Files         863      864       +1     
     Lines       40978    41059      +81     
     Branches     3693     3697       +4     
   ==========================================
   + Hits        25516    25543      +27     
   - Misses      15283    15337      +54     
     Partials      179      179              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.07%)` | :arrow_up: |
   | #python | `61.78% <100.00%> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.22% <0.00%> (-0.14%)` | :arrow_down: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#discussion_r513654251



##########
File path: superset/charts/schemas.py
##########
@@ -705,7 +705,94 @@ class ChartDataExtrasSchema(Schema):
     )
 
 
+class AnnotationLayerSchema(Schema):
+    annotationType = fields.String(

Review comment:
       Unfortunately not, this is what the state from the control looks like, and it would feel wrong to map it over from camel to kebab.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **increase** coverage by `4.23%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   + Coverage   62.26%   66.50%   +4.23%     
   ==========================================
     Files         863      864       +1     
     Lines       40978    41062      +84     
     Branches     3693     3697       +4     
   ==========================================
   + Hits        25516    27309    +1793     
   + Misses      15283    13652    -1631     
   + Partials      179      101      -78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.20% <ø> (?)` | |
   | #javascript | `62.95% <ø> (+0.07%)` | :arrow_up: |
   | #python | `61.95% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <0.00%> (ø)` | |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `92.30% <0.00%> (ø)` | |
   | ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **increase** coverage by `4.37%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   + Coverage   62.26%   66.64%   +4.37%     
   ==========================================
     Files         863      864       +1     
     Lines       40978    41062      +84     
     Branches     3693     3697       +4     
   ==========================================
   + Hits        25516    27365    +1849     
   + Misses      15283    13600    -1683     
   + Partials      179       97      -82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.83% <ø> (?)` | |
   | #javascript | `62.95% <ø> (+0.07%)` | :arrow_up: |
   | #python | `61.95% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <0.00%> (ø)` | |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `92.30% <0.00%> (ø)` | |
   | ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **decrease** coverage by `0.35%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   - Coverage   62.26%   61.91%   -0.36%     
   ==========================================
     Files         863      864       +1     
     Lines       40978    41059      +81     
     Branches     3693     3697       +4     
   ==========================================
   - Hits        25516    25422      -94     
   - Misses      15283    15458     +175     
     Partials      179      179              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.07%)` | :arrow_up: |
   | #python | `61.31% <100.00%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#discussion_r513646016



##########
File path: superset/charts/schemas.py
##########
@@ -705,7 +705,94 @@ class ChartDataExtrasSchema(Schema):
     )
 
 
+class AnnotationLayerSchema(Schema):
+    annotationType = fields.String(

Review comment:
       We are mixing camel case with snake case, can we change it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#discussion_r513654251



##########
File path: superset/charts/schemas.py
##########
@@ -705,7 +705,94 @@ class ChartDataExtrasSchema(Schema):
     )
 
 
+class AnnotationLayerSchema(Schema):
+    annotationType = fields.String(

Review comment:
       Unfortunately not, this is what the state from the control looks like, and it would feel wrong to map it over from camel to snake.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   + Coverage   62.26%   62.31%   +0.05%     
   ==========================================
     Files         863      864       +1     
     Lines       40978    41059      +81     
     Branches     3693     3697       +4     
   ==========================================
   + Hits        25516    25587      +71     
   - Misses      15283    15293      +10     
     Partials      179      179              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.07%)` | :arrow_up: |
   | #python | `61.95% <100.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <0.00%> (ø)` | |
   | [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `92.30% <0.00%> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `71.11% <0.00%> (+0.32%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **decrease** coverage by `0.95%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   - Coverage   62.26%   61.31%   -0.96%     
   ==========================================
     Files         863      417     -446     
     Lines       40978    26000   -14978     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25516    15942    -9574     
   + Misses      15283    10058    -5225     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.31% <100.00%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#discussion_r512531097



##########
File path: superset/charts/schemas.py
##########
@@ -817,6 +900,19 @@ class ChartDataQueryObjectSchema(Schema):
         "as `having_druid`.",
         deprecated=True,
     )
+    druid_time_origin = fields.String(
+        description="Starting point for time grain counting on legacy Druid "
+        "datasources. Used to change e.g. Monday/Sunday first-day-of-week. "
+        "This field is deprecated and should be passed to `extras` "
+        "as `druid_time_origin`.",
+        allow_none=True,
+    )
+    url_params = fields.Dict(
+        description="Optional query parameters passed to a dashboard or Explore view",
+        keys=fields.String(description="The query parameter"),
+        values=fields.String(description="The value of the query parameter"),
+        allow_none=True,
+    )

Review comment:
       Bycatch: this was missing, is added to `superset-ui/core` in the related PR (see description), after which url params can be used in v1 chart data requests with jinja templates.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   - Coverage   62.26%   62.21%   -0.06%     
   ==========================================
     Files         863      864       +1     
     Lines       40978    41059      +81     
     Branches     3693     3697       +4     
   ==========================================
   + Hits        25516    25544      +28     
   - Misses      15283    15336      +53     
     Partials      179      179              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.95% <ø> (+0.07%)` | :arrow_up: |
   | #python | `61.78% <100.00%> (-0.13%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.22% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11393: chore(chart-data): add annotations and url params to chart data schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11393:
URL: https://github.com/apache/incubator-superset/pull/11393#issuecomment-718213370


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=h1) Report
   > Merging [#11393](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4d547c30aaa44244ca5afdf34033c973af92f10?el=desc) will **decrease** coverage by `0.93%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11393/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11393      +/-   ##
   ==========================================
   - Coverage   62.26%   61.32%   -0.94%     
   ==========================================
     Files         863      417     -446     
     Lines       40978    25989   -14989     
     Branches     3693        0    -3693     
   ==========================================
   - Hits        25516    15939    -9577     
   + Misses      15283    10050    -5233     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.32% <100.00%> (-0.59%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.42% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.99% <100.00%> (+0.25%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <0.00%> (-1.49%)` | :arrow_down: |
   | ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11393/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=footer). Last update [d4d547c...354535d](https://codecov.io/gh/apache/incubator-superset/pull/11393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org