You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/24 18:32:51 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #5726: Trigger docs CI build on changes to asf.yaml

alamb opened a new pull request, #5726:
URL: https://github.com/apache/arrow-datafusion/pull/5726

   # Which issue does this PR close?
   
   Related to #5500 
   
   # Rationale for this change
   
   Publishing the docs is configured  by `asf.yaml` and thus if that files changes we should also retrigger the docs workflow
   
   As suggested by @kou  on  https://github.com/apache/arrow-datafusion/pull/5703#pullrequestreview-1355709963
   
   # What changes are included in this PR?
   1. Trigger docs CI build on changes to asf.yaml
   
   # Are these changes tested?
   No
   
   # Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] kou merged pull request #5726: Minor: Trigger docs CI build on changes to asf.yaml

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #5726:
URL: https://github.com/apache/arrow-datafusion/pull/5726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5726: Trigger docs CI build on changes to asf.yaml

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5726:
URL: https://github.com/apache/arrow-datafusion/pull/5726#discussion_r1147935462


##########
datafusion/core/tests/parquet/row_group_pruning.rs:
##########
@@ -511,7 +511,7 @@ async fn prune_periods_in_column_names() {
         Scenario::PeriodsInColumnNames,
         "SELECT \"name\", \"service.name\" FROM t WHERE \"service.name\" = 'frontend' AND \"name\" != 'HTTP GET / DISPATCH'",
         Some(0),
-        Some(2), // prune out  middle and last row group
+        Some(2), // prune out middle and last row group

Review Comment:
   drive by cleanup



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org