You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/25 01:19:09 UTC
[GitHub] [kafka] guozhangwang opened a new pull request #8925: KAFKA-9974: Make produce-sync flush
guozhangwang opened a new pull request #8925:
URL: https://github.com/apache/kafka/pull/8925
I cannot actually re-produce the failure locally, but by looking at the code I think there's an issue in `produceKeyValuesSynchronously`: when Eos is not enabled, we then need to call `flush` to make sure all records are indeed sent "synchronously". If Eos is enabled the `commitTxn` would flush the records already.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Integration test shouldApplyUpdatesToStandbyStore; Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-651402509
`MirrorConnectorsIntegrationTest` are actually failing in trunk as well, I will ping corresponding folks for it. cc @abbccdda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-650414999
Is Jenkins linking to the wrong builds? When I try to see which tests failed here it seems to bring me to the results for two completely different PRs.
Really dropping the ball lately Mr. Jenkins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Integration test shouldApplyUpdatesToStandbyStore; Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-651396758
test this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-649157606
test this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda merged pull request #8925: KAFKA-9974: Integration test shouldApplyUpdatesToStandbyStore; Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #8925:
URL: https://github.com/apache/kafka/pull/8925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-649157235
test this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-649157091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8925: KAFKA-9974: Integration test shouldApplyUpdatesToStandbyStore; Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-651243387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-650487412
> Could we include the purpose of this PR in the title, such as "Integration test shouldApplyUpdatesToStandbyStore fix:... "
SG
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-650486850
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang removed a comment on pull request #8925: KAFKA-9974: Make produce-sync flush
Posted by GitBox <gi...@apache.org>.
guozhangwang removed a comment on pull request #8925:
URL: https://github.com/apache/kafka/pull/8925#issuecomment-649157091
test this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org