[GitHub] [mynewt-core] agross-korg commented on a diff in pull request #2884: Flash autoconfigure updates

[GitBox <gi...@apache.org>]

agross-korg commented on code in PR #2884:
URL: https://github.com/apache/mynewt-core/pull/2884#discussion_r981492275


##########
hw/mcu/dialog/da1469x/src/hal_flash.c:
##########
@@ -430,6 +430,9 @@ qspi_read_rdid(const struct hal_flash *dev)
     int i;
     uint32_t result;
 
+    da1469x_qspi_mode_manual(dev);
+    da1469x_qspi_wait_busy(dev);

Review Comment:
   The main reason is that we had been using the read_rdid call directly in other places and I found that it made more sense to make function calls independent from people who call them, especially if you are issuing commands which may leave the chip in an odd state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org