You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/07 01:06:57 UTC

Review Request 33920: Set verbose=False in the client to squelch noisy ZooKeeper logging.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Zameer Manji.


Repository: aurora


Description
-------

This flag has a long thread that lands in `TwitterKazooClient`.  The proposed change will mean that INFO-level ZooKeeper client logging is never shown.

Zameer notes that this regressed in https://reviews.apache.org/r/32905, where he decided that the verbose kwarg was effectively ineffective, and he defaulted to True for safety.


Diffs
-----

  src/main/python/apache/aurora/client/cli/context.py 146960ec4a4a5e958075990085cb1bb58a51eff0 

Diff: https://reviews.apache.org/r/33920/diff/


Testing
-------

Before:
```
$ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora --watch
 INFO] Starting update for: http_example
 INFO] Connecting to 192.168.33.7:2181
 INFO] Sending request(xid=None): Connect(protocol_version=0, last_zxid_seen=0, time_out=10000, session_id=0, passwd='\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00', read_only=None)
 INFO] Zookeeper connection established, state: CONNECTED
 INFO] Sending request(xid=1): GetChildren(path=u'/aurora/scheduler', watcher=<function get_watch at 0x7f06783a8938>)
 INFO] Received response(xid=1): [u'member_0000000011', u'singleton_candidate_0000000010']
 INFO] Sending request(xid=2): GetData(path=u'/aurora/scheduler/member_0000000011', watcher=None)
 INFO] Received response(xid=2): ('{"serviceEndpoint":{"host":"192.168.33.7","port":8081},"additionalEndpoints":{"http":{"host":"192.168.33.7","port":8081}},"status":"ALIVE"}', ZnodeStat(czxid=351, mzxid=351, ctime=1430942244998, mtime=1430942244998, version=0, cversion=0, aversion=0, ephemeralOwner=93778139510669447, dataLength=139, numChildren=0, pzxid=351))
 INFO] Sending request(xid=3): GetChildren(path=u'/aurora/scheduler', watcher=None)
 INFO] Received response(xid=3): [u'member_0000000011', u'singleton_candidate_0000000010']
 INFO] Sending request(xid=4): Close()
 INFO] Closing connection to 192.168.33.7:2181
 INFO] Zookeeper session lost, state: CLOSED
Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/0cce84b1-36d8-4a44-95ec-8c2cee02b8ca
Entered state ROLLING_FORWARD
Entered state ROLLED_FORWARD
```

After:
```
$ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora --watch
 INFO] Starting update for: http_example
Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/f8d7bd24-b44c-41a0-aacb-f4a0568a7fff
Entered state ROLLING_FORWARD
Entered state ROLLED_FORWARD
```


Thanks,

Bill Farner


Re: Review Request 33920: Set verbose=False in the client to squelch noisy ZooKeeper logging.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/#review82764
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On May 6, 2015, 4:06 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33920/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 4:06 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This flag has a long thread that lands in `TwitterKazooClient`.  The proposed change will mean that INFO-level ZooKeeper client logging is never shown.
> 
> Zameer notes that this regressed in https://reviews.apache.org/r/32905, where he decided that the verbose kwarg was effectively ineffective, and he defaulted to True for safety.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 146960ec4a4a5e958075990085cb1bb58a51eff0 
> 
> Diff: https://reviews.apache.org/r/33920/diff/
> 
> 
> Testing
> -------
> 
> Before:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora --watch
>  INFO] Starting update for: http_example
>  INFO] Connecting to 192.168.33.7:2181
>  INFO] Sending request(xid=None): Connect(protocol_version=0, last_zxid_seen=0, time_out=10000, session_id=0, passwd='\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00', read_only=None)
>  INFO] Zookeeper connection established, state: CONNECTED
>  INFO] Sending request(xid=1): GetChildren(path=u'/aurora/scheduler', watcher=<function get_watch at 0x7f06783a8938>)
>  INFO] Received response(xid=1): [u'member_0000000011', u'singleton_candidate_0000000010']
>  INFO] Sending request(xid=2): GetData(path=u'/aurora/scheduler/member_0000000011', watcher=None)
>  INFO] Received response(xid=2): ('{"serviceEndpoint":{"host":"192.168.33.7","port":8081},"additionalEndpoints":{"http":{"host":"192.168.33.7","port":8081}},"status":"ALIVE"}', ZnodeStat(czxid=351, mzxid=351, ctime=1430942244998, mtime=1430942244998, version=0, cversion=0, aversion=0, ephemeralOwner=93778139510669447, dataLength=139, numChildren=0, pzxid=351))
>  INFO] Sending request(xid=3): GetChildren(path=u'/aurora/scheduler', watcher=None)
>  INFO] Received response(xid=3): [u'member_0000000011', u'singleton_candidate_0000000010']
>  INFO] Sending request(xid=4): Close()
>  INFO] Closing connection to 192.168.33.7:2181
>  INFO] Zookeeper session lost, state: CLOSED
> Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/0cce84b1-36d8-4a44-95ec-8c2cee02b8ca
> Entered state ROLLING_FORWARD
> Entered state ROLLED_FORWARD
> ```
> 
> After:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora --watch
>  INFO] Starting update for: http_example
> Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/f8d7bd24-b44c-41a0-aacb-f4a0568a7fff
> Entered state ROLLING_FORWARD
> Entered state ROLLED_FORWARD
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33920: Set verbose=False in the client to squelch noisy ZooKeeper logging.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/#review82765
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On May 6, 2015, 4:06 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33920/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 4:06 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This flag has a long thread that lands in `TwitterKazooClient`.  The proposed change will mean that INFO-level ZooKeeper client logging is never shown.
> 
> Zameer notes that this regressed in https://reviews.apache.org/r/32905, where he decided that the verbose kwarg was effectively ineffective, and he defaulted to True for safety.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 146960ec4a4a5e958075990085cb1bb58a51eff0 
> 
> Diff: https://reviews.apache.org/r/33920/diff/
> 
> 
> Testing
> -------
> 
> Before:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora --watch
>  INFO] Starting update for: http_example
>  INFO] Connecting to 192.168.33.7:2181
>  INFO] Sending request(xid=None): Connect(protocol_version=0, last_zxid_seen=0, time_out=10000, session_id=0, passwd='\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00', read_only=None)
>  INFO] Zookeeper connection established, state: CONNECTED
>  INFO] Sending request(xid=1): GetChildren(path=u'/aurora/scheduler', watcher=<function get_watch at 0x7f06783a8938>)
>  INFO] Received response(xid=1): [u'member_0000000011', u'singleton_candidate_0000000010']
>  INFO] Sending request(xid=2): GetData(path=u'/aurora/scheduler/member_0000000011', watcher=None)
>  INFO] Received response(xid=2): ('{"serviceEndpoint":{"host":"192.168.33.7","port":8081},"additionalEndpoints":{"http":{"host":"192.168.33.7","port":8081}},"status":"ALIVE"}', ZnodeStat(czxid=351, mzxid=351, ctime=1430942244998, mtime=1430942244998, version=0, cversion=0, aversion=0, ephemeralOwner=93778139510669447, dataLength=139, numChildren=0, pzxid=351))
>  INFO] Sending request(xid=3): GetChildren(path=u'/aurora/scheduler', watcher=None)
>  INFO] Received response(xid=3): [u'member_0000000011', u'singleton_candidate_0000000010']
>  INFO] Sending request(xid=4): Close()
>  INFO] Closing connection to 192.168.33.7:2181
>  INFO] Zookeeper session lost, state: CLOSED
> Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/0cce84b1-36d8-4a44-95ec-8c2cee02b8ca
> Entered state ROLLING_FORWARD
> Entered state ROLLED_FORWARD
> ```
> 
> After:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora --watch
>  INFO] Starting update for: http_example
> Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/f8d7bd24-b44c-41a0-aacb-f4a0568a7fff
> Entered state ROLLING_FORWARD
> Entered state ROLLED_FORWARD
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33920: Set verbose=False in the client to squelch noisy ZooKeeper logging.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/#review82767
-----------------------------------------------------------


Master (fc9cb02) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Wed May  6 23:10:19 UTC 2015
+ ./gradlew -Pq clean build
Downloading https://services.gradle.org/distributions/gradle-2.4-bin.zip
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
 .....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
 ..................................................................................................................................................................................................................................................................................
Unzipping /home/jenkins/.gradle/wrapper/dists/gradle-2.4-bin/1lebsnfoptv8qpa10w6kyy5mp/gradle-2.4-bin.zip to /home/jenkins/.gradle/wrapper/dists/gradle-2.4-bin/1lebsnfoptv8qpa10w6kyy5mp
Set executable permissions for: /home/jenkins/.gradle/wrapper/dists/gradle-2.4-bin/1lebsnfoptv8qpa10w6kyy5mp/gradle-2.4/bin/gradle
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not resolve all dependencies for configuration ':classpath'.
   > Could not download maven-compat.jar (org.apache.maven:maven-compat:3.0-alpha-2)
      > Failed to download SHA1 for resource 'http://plugins.gradle.org/m2/org/apache/maven/maven-compat/3.0-alpha-2/maven-compat-3.0-alpha-2.jar'.
         > Could not GET 'http://plugins.gradle.org/m2/org/apache/maven/maven-compat/3.0-alpha-2/maven-compat-3.0-alpha-2.jar.sha1'.
            > peer not authenticated

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 4.417 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 6, 2015, 11:06 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33920/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 11:06 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This flag has a long thread that lands in `TwitterKazooClient`.  The proposed change will mean that INFO-level ZooKeeper client logging is never shown.
> 
> Zameer notes that this regressed in https://reviews.apache.org/r/32905, where he decided that the verbose kwarg was effectively ineffective, and he defaulted to True for safety.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 146960ec4a4a5e958075990085cb1bb58a51eff0 
> 
> Diff: https://reviews.apache.org/r/33920/diff/
> 
> 
> Testing
> -------
> 
> Before:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora --watch
>  INFO] Starting update for: http_example
>  INFO] Connecting to 192.168.33.7:2181
>  INFO] Sending request(xid=None): Connect(protocol_version=0, last_zxid_seen=0, time_out=10000, session_id=0, passwd='\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00', read_only=None)
>  INFO] Zookeeper connection established, state: CONNECTED
>  INFO] Sending request(xid=1): GetChildren(path=u'/aurora/scheduler', watcher=<function get_watch at 0x7f06783a8938>)
>  INFO] Received response(xid=1): [u'member_0000000011', u'singleton_candidate_0000000010']
>  INFO] Sending request(xid=2): GetData(path=u'/aurora/scheduler/member_0000000011', watcher=None)
>  INFO] Received response(xid=2): ('{"serviceEndpoint":{"host":"192.168.33.7","port":8081},"additionalEndpoints":{"http":{"host":"192.168.33.7","port":8081}},"status":"ALIVE"}', ZnodeStat(czxid=351, mzxid=351, ctime=1430942244998, mtime=1430942244998, version=0, cversion=0, aversion=0, ephemeralOwner=93778139510669447, dataLength=139, numChildren=0, pzxid=351))
>  INFO] Sending request(xid=3): GetChildren(path=u'/aurora/scheduler', watcher=None)
>  INFO] Received response(xid=3): [u'member_0000000011', u'singleton_candidate_0000000010']
>  INFO] Sending request(xid=4): Close()
>  INFO] Closing connection to 192.168.33.7:2181
>  INFO] Zookeeper session lost, state: CLOSED
> Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/0cce84b1-36d8-4a44-95ec-8c2cee02b8ca
> Entered state ROLLING_FORWARD
> Entered state ROLLED_FORWARD
> ```
> 
> After:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora --watch
>  INFO] Starting update for: http_example
> Job update has started. View your update progress at http://192.168.33.7:8081/scheduler/vagrant/test/http_example/f8d7bd24-b44c-41a0-aacb-f4a0568a7fff
> Entered state ROLLING_FORWARD
> Entered state ROLLED_FORWARD
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>