You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/07/07 11:15:22 UTC

Review Request 60704: Handled EINTR for `waitpid()` in ChildHook::SUPERVISOR from subprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60704/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and James Peach.


Bugs: MESOS-7160
    https://issues.apache.org/jira/browse/MESOS-7160


Repository: mesos


Description
-------

Handled EINTR for `waitpid()` in ChildHook::SUPERVISOR from subprocess.


Diffs (updated)
-----

  3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 


Diff: https://reviews.apache.org/r/60704/diff/1/


Testing (updated)
-------

make check (mac os x, fedora 25)


Thanks,

Andrei Budnik


Re: Review Request 60704: Handled EINTR for `waitpid()` in ChildHook::SUPERVISOR from subprocess.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60704/#review179866
-----------------------------------------------------------


Ship it!




Thanks for the cleanup!

- Benjamin Bannier


On July 7, 2017, 1:15 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60704/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and James Peach.
> 
> 
> Bugs: MESOS-7160
>     https://issues.apache.org/jira/browse/MESOS-7160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Handled EINTR for `waitpid()` in ChildHook::SUPERVISOR from subprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 
> 
> 
> Diff: https://reviews.apache.org/r/60704/diff/1/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>