[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #3052: [#3028] Increase test coverage of a binding mode of camel-rest component

[GitBox <gi...@apache.org>]

ppalaga commented on a change in pull request #3052:
URL: https://github.com/apache/camel-quarkus/pull/3052#discussion_r698370055



##########
File path: integration-tests/rest/src/main/java/org/apache/camel/quarkus/component/rest/it/RestResource.java
##########
@@ -68,4 +68,26 @@ public String restProducer(@QueryParam("port") int port) {
         return producerTemplate.requestBodyAndHeaders(
                 "rest:get:/rest/template/{messageStart}/{messageEnd}?host=localhost:" + port, null, headers, String.class);
     }
+
+    @Path("/producer/binding/mode/json")
+    @GET
+    @Produces(MediaType.APPLICATION_JSON)
+    public Person restProducerBindingModeJson(@QueryParam("port") int port) {
+        String query = "rest:get:/rest/binding/json/producer" +
+                "?bindingMode=json" +
+                "&outType=org.apache.camel.quarkus.component.rest.it.Person" +
+                "&host=localhost:" + port;

Review comment:
       Looking at this, I am am why we need a JAX-RS endpoint to test the rest component? This is perhaps a way to pass `bindingMode=json`, but it it can also be passed via REST DSL, which we already did before this PR, see https://github.com/apache/camel-quarkus/pull/3052/files#diff-58cbc36531a538cc13ef975a1889ac4ec3b28c54786b5896118916846558a592R64-R71 for JSON and https://github.com/apache/camel-quarkus/pull/3052/files#diff-58cbc36531a538cc13ef975a1889ac4ec3b28c54786b5896118916846558a592R78-R85 for XML. 
   Is this PR adding anything new the above two exist?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org