You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/17 10:24:38 UTC
[GitHub] [kafka] jlprat opened a new pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
jlprat opened a new pull request #10710:
URL: https://github.com/apache/kafka/pull/10710
Removes previously deprecated methods in older KIPs
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-849484765
Failed test is unrelated and known to be flaky:
```
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a change in pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
jlprat commented on a change in pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#discussion_r633413175
##########
File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KTable.scala
##########
@@ -304,7 +304,7 @@ class KTable[K, V](val inner: KTableJ[K, V]) {
new KStream(inner.toStream[KR](mapper.asKeyValueMapper, named))
/**
- * Suppress some updates from this changelog stream, determined by the supplied [[Suppressed]] configuration.
+ * Suppress some updates from this changelog stream, determined by the supplied [[org.apache.kafka.streams.kstream.Suppressed]] configuration.
Review comment:
Use the right non-deprecated class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-849486858
Thanks for the review @cadonna !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #10710:
URL: https://github.com/apache/kafka/pull/10710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a change in pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
jlprat commented on a change in pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#discussion_r633413175
##########
File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KTable.scala
##########
@@ -304,7 +304,7 @@ class KTable[K, V](val inner: KTableJ[K, V]) {
new KStream(inner.toStream[KR](mapper.asKeyValueMapper, named))
/**
- * Suppress some updates from this changelog stream, determined by the supplied [[Suppressed]] configuration.
+ * Suppress some updates from this changelog stream, determined by the supplied [[org.apache.kafka.streams.kstream.Suppressed]] configuration.
Review comment:
Use the right non-deprecated class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-842288466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-842288466
cc @cadonna PR is ready for review, if you would like to take a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-842510628
As discussed with @ableegoldman only classes deprecated since at least 2.5 can be removed. For this reason, `Serdes` can't be removed yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org