You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sanjay Radia (JIRA)" <ji...@apache.org> on 2012/05/07 20:47:03 UTC

[jira] [Created] (HADOOP-8367) ProtoBufRpcEngine's rpc request header does not need declaringClass name

Sanjay Radia created HADOOP-8367:
------------------------------------

             Summary: ProtoBufRpcEngine's rpc request header does not need declaringClass name
                 Key: HADOOP-8367
                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
             Project: Hadoop Common
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Sanjay Radia
            Assignee: Sanjay Radia




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Status: Patch Available  (was: Open)
    
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Status: Open  (was: Patch Available)
    
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HADOOP-8367) Improve documentation of declaringClassProtocolName in rpc headers

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HADOOP-8367.
---------------------------------

    
> Improve documentation of declaringClassProtocolName in rpc headers 
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 2.0.2-alpha
>
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281821#comment-13281821 ] 

Hadoop QA commented on HADOOP-8367:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528763/hadoop-8367-2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1025//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1025//console

This message is automatically generated.
                
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Attachment: hadoop-8367-1.patch
    
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Summary: Better document the declaringClassProtocolName in the rpc headers better  (was: ProtoBufRpcEngine's rpc request header does not need declaringClass name)
    
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) ProtoBufRpcEngine's rpc request header does not need declaringClass name

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269881#comment-13269881 ] 

Sanjay Radia commented on HADOOP-8367:
--------------------------------------

The declaring-class name was added to the writable rpc engine's header to deal with the VersionedProtocol. Not needed for PB since version number is handled differently.
                
> ProtoBufRpcEngine's rpc request header does not need declaringClass name
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) Improve documentation of declaringClassProtocolName in rpc headers

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281940#comment-13281940 ] 

Hudson commented on HADOOP-8367:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2358 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2358/])
    HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051)

     Result = SUCCESS
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto

                
> Improve documentation of declaringClassProtocolName in rpc headers 
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 2.0.1-alpha
>
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273778#comment-13273778 ] 

Hadoop QA commented on HADOOP-8367:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526594/hadoop-8367-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/988//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/988//console

This message is automatically generated.
                
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) Improve documentation of declaringClassProtocolName in rpc headers

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281967#comment-13281967 ] 

Hudson commented on HADOOP-8367:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2285 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2285/])
    HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051)

     Result = SUCCESS
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto

                
> Improve documentation of declaringClassProtocolName in rpc headers 
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 2.0.1-alpha
>
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Attachment: hadoop-8367-2.patch
    
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) Improve documentation of declaringClassProtocolName in rpc headers

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282003#comment-13282003 ] 

Hudson commented on HADOOP-8367:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2303 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2303/])
    HADOOP-8367 Improve documentation of declaringClassProtocolName in rpc headers (Sanjay Radia) (Revision 1342051)

     Result = FAILURE
sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342051
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/hadoop_rpc.proto

                
> Improve documentation of declaringClassProtocolName in rpc headers 
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 2.0.1-alpha
>
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276902#comment-13276902 ] 

Suresh Srinivas commented on HADOOP-8367:
-----------------------------------------

Minor comments:
# ProtobufRpcEngine.java
#* Typo differnt
#* The newly added comment is not very clear. Can you please add more information about what you mean by metaProtocols. Also the sentense does not read right. It might make sense to capture the same comments from hadoop_rpc.proto in here.
# hadoop_rpc.proto some lines are going beyond 80 characters. Also the last sentence in the newly added comment does not read right.

                
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Improve documentation of declaringClassProtocolName in rpc headers

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.1-alpha
           Status: Resolved  (was: Patch Available)

New tests not needed - javadoc improvements.
Committed.
                
> Improve documentation of declaringClassProtocolName in rpc headers 
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 2.0.1-alpha
>
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Improve documentation of declaringClassProtocolName in rpc headers

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Summary: Improve documentation of declaringClassProtocolName in rpc headers   (was: Better document the declaringClassProtocolName in the rpc headers better)
    
> Improve documentation of declaringClassProtocolName in rpc headers 
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch, hadoop-8367-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8367) ProtoBufRpcEngine's rpc request header does not need declaringClass name

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273757#comment-13273757 ] 

Sanjay Radia commented on HADOOP-8367:
--------------------------------------

I was wrong here. Since the connection is reused, the declaringClassProtocolName is needed.
Will better document this in the code; will change the jira title to do this.
                
> ProtoBufRpcEngine's rpc request header does not need declaringClass name
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8367) Better document the declaringClassProtocolName in the rpc headers better

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-8367:
---------------------------------

    Status: Patch Available  (was: Open)
    
> Better document the declaringClassProtocolName in the rpc headers better
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-8367
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8367
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hadoop-8367-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira