You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/09/26 20:09:40 UTC

[GitHub] [arrow] kou commented on a diff in pull request #37436: GH-35600: [Python] Allow setting path to timezone db through python API

kou commented on code in PR #37436:
URL: https://github.com/apache/arrow/pull/37436#discussion_r1337723049


##########
ci/appveyor-cpp-build.bat:
##########
@@ -132,6 +132,17 @@ set ARROW_HOME=%CONDA_PREFIX%\Library
 @rem ARROW-3075; pkgconfig is broken for Parquet for now
 set PARQUET_HOME=%CONDA_PREFIX%\Library
 
+@rem Download IANA Timezone Database to a non-standard location to
+@rem test the configurability of the timezone database path
+curl https://data.iana.org/time-zones/releases/tzdata2021e.tar.gz --output tzdata.tar.gz || exit /B
+mkdir tzdata
+tar --extract --file tzdata.tar.gz --directory tzdata
+mkdir %USERPROFILE%\Downloads\test
+move tzdata %USERPROFILE%\Downloads\test\

Review Comment:
   Can we simplify them?
   
   ```suggestion
   mkdir %USERPROFILE%\Downloads\test\tzdata
   tar --extract --file tzdata.tar.gz --directory %USERPROFILE%\Downloads\test\tzdata
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org