You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/09/15 17:57:26 UTC
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10639: Fixing row_size calculation when bpp is equal 1 in lcd_dev driver
pkarashchenko commented on code in PR #10639:
URL: https://github.com/apache/nuttx/pull/10639#discussion_r1327622049
##########
drivers/lcd/lcd_dev.c:
##########
@@ -118,7 +118,8 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
FAR struct lcddev_area_s *lcd_area =
(FAR struct lcddev_area_s *)arg;
size_t cols = lcd_area->col_end - lcd_area->col_start + 1;
- size_t row_size = cols * (priv->planeinfo.bpp >> 3);
+ size_t row_size = cols * (priv->planeinfo.bpp > 1 ?
Review Comment:
based on the code it looks more like `priv->planeinfo.bpp > 8` condition is appropriate, but I didn't dive deep into details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org