You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/04/06 18:03:24 UTC
Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts to
common services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Bugs: AMBARI-10367
https://issues.apache.org/jira/browse/AMBARI-10367
Repository: ambari
Description
-------
[WinTP2] Merge HDPWIN HBASE package scripts to common services
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_mapping.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
Diff: https://reviews.apache.org/r/32884/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [4.603s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
[INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts
to common services
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/#review79483
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On April 8, 2015, 11:22 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32884/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 11:22 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10367
> https://issues.apache.org/jira/browse/AMBARI-10367
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Merge HDPWIN HBASE package scripts to common services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py c945049
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
>
> Diff: https://reviews.apache.org/r/32884/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.603s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
> [INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts
to common services
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/#review79643
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 8, 2015, 11:22 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32884/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 11:22 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10367
> https://issues.apache.org/jira/browse/AMBARI-10367
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Merge HDPWIN HBASE package scripts to common services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py c945049
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
>
> Diff: https://reviews.apache.org/r/32884/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.603s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
> [INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts
to common services
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/
-----------------------------------------------------------
(Updated Апрель 8, 2015, 11:22 п.п.)
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Bugs: AMBARI-10367
https://issues.apache.org/jira/browse/AMBARI-10367
Repository: ambari
Description
-------
[WinTP2] Merge HDPWIN HBASE package scripts to common services
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py c945049
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
Diff: https://reviews.apache.org/r/32884/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [4.603s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
[INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts
to common services
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/#review79366
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
<https://reviews.apache.org/r/32884/#comment128630>
The Windows implementation of install looks wrong. It will not work if HbaseClient is the only component or is the first component to be installed on the host. It doesnt install the HDP MSI.
Also if we do call self.install_packages for Windows,then the code will become identical and should move to the base class.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
<https://reviews.apache.org/r/32884/#comment128632>
The Windows implementation of configure() looks wrong. We are not saving any configs here and just like Linux, we should be calling hbase(name="client") to save the configs.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
<https://reviews.apache.org/r/32884/#comment128628>
Move status to HbaseClient as the implementation is same for windows and linux.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
<https://reviews.apache.org/r/32884/#comment128634>
We dont need this check anymore. Eugene changed the MSI installation to add a marker file to check if the MSI has already been installed. So the code will be identical to Linux
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
<https://reviews.apache.org/r/32884/#comment128635>
Make configure code same as Linux and refactor. We are already forking out hbase() itself
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
<https://reviews.apache.org/r/32884/#comment128636>
Code is same as Linux. Refactor out to base class.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
<https://reviews.apache.org/r/32884/#comment128637>
Service install check is not needed as I mentioned above. Refactor the code.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
<https://reviews.apache.org/r/32884/#comment128638>
Make configure code for windows same as linux.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
<https://reviews.apache.org/r/32884/#comment128639>
Common code. Refactor to base
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_mapping.py
<https://reviews.apache.org/r/32884/#comment128631>
We dont need to add this additional file for config params. Move those params to status_params.py. See OOZIE for reference.
- Jayush Luniya
On April 6, 2015, 4:03 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32884/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 4:03 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10367
> https://issues.apache.org/jira/browse/AMBARI-10367
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Merge HDPWIN HBASE package scripts to common services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_mapping.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
>
> Diff: https://reviews.apache.org/r/32884/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.603s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
> [INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts
to common services
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On Апрель 6, 2015, 4:23 п.п., Florian Barca wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py, line 38
> > <https://reviews.apache.org/r/32884/diff/1/?file=916480#file916480line38>
> >
> > Ths specific code starts here. How about keeping the if+hosts=...+for+if host common, and use a specific function to handle the task? Something like:
> > if params.hbase_drain_only == True:
> > decommission_fn = decommission_drain_only
> > else:
> > decommission_fn = decommission_normal
Think we don't need to complicate the codes by creating of separate methods which will only execute the different commands. I did some refactoring here but only for reduce the line count. Think that is what you meant but without splitting the method.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/#review78926
-----------------------------------------------------------
On Апрель 8, 2015, 11:22 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32884/
> -----------------------------------------------------------
>
> (Updated Апрель 8, 2015, 11:22 п.п.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10367
> https://issues.apache.org/jira/browse/AMBARI-10367
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Merge HDPWIN HBASE package scripts to common services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py c945049
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
>
> Diff: https://reviews.apache.org/r/32884/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.603s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
> [INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32884: [WinTP2] Merge HDPWIN HBASE package scripts
to common services
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32884/#review78926
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
<https://reviews.apache.org/r/32884/#comment128022>
This looks like common code, suggest moving it outside the if/else.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
<https://reviews.apache.org/r/32884/#comment128023>
Ths specific code starts here. How about keeping the if+hosts=...+for+if host common, and use a specific function to handle the task? Something like:
if params.hbase_drain_only == True:
decommission_fn = decommission_drain_only
else:
decommission_fn = decommission_normal
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
<https://reviews.apache.org/r/32884/#comment128024>
Seen this exact sequence copy-pasted many times. Isn't there a way to use metaclasses to skip writing this kind of repetitive code?
- Florian Barca
On April 6, 2015, 4:03 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32884/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 4:03 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10367
> https://issues.apache.org/jira/browse/AMBARI-10367
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Merge HDPWIN HBASE package scripts to common services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 06e0481
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py f66ea16
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py a623927
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py 21bd31d
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py d7c5bf9
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py eea1cd1
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_mapping.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb a3958a6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py b0a52bb
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py bf2aad0
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py f2a2ad6
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py d3720d5
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py e4777a4
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py cd9a74a
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py c12967b
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py 186b64e
>
> Diff: https://reviews.apache.org/r/32884/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.603s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.440s]
> [INFO] Ambari Server ..................................... SUCCESS [1:18.444s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>