You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:56:15 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #12877: ARROW-5598: [Go] Rename array.Array{,Approx}Equal to array.{,Approx}Equal
zeroshade opened a new pull request, #12877:
URL: https://github.com/apache/arrow/pull/12877
Also renames `ArraySliceEqual` and `ArraySliceApproxEqual` to `SliceEqual` and `SliceApproxEqual` accordingly.
Leaves the original names existing with deprecation messages that will show up in the documentation so that consumers aren't negatively effected. The deprecated versions can be removed for v9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #12877: ARROW-5598: [Go] Rename array.Array{,Approx}Equal to array.{,Approx}Equal
Posted by GitBox <gi...@apache.org>.
emkornfield commented on PR #12877:
URL: https://github.com/apache/arrow/pull/12877#issuecomment-1103372027
+1 LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #12877: ARROW-5598: [Go] Rename array.Array{,Approx}Equal to array.{,Approx}Equal
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12877: ARROW-5598: [Go] Rename array.Array{,Approx}Equal to array.{,Approx}Equal
URL: https://github.com/apache/arrow/pull/12877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12877: ARROW-5598: [Go] Rename array.Array{,Approx}Equal to array.{,Approx}Equal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12877:
URL: https://github.com/apache/arrow/pull/12877#issuecomment-1098268316
https://issues.apache.org/jira/browse/ARROW-5598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12877: ARROW-5598: [Go] Rename array.Array{,Approx}Equal to array.{,Approx}Equal
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12877:
URL: https://github.com/apache/arrow/pull/12877#issuecomment-1107793660
Benchmark runs are scheduled for baseline = 61655b34f14e23fff217c314f60bbee92fe7961f and contender = f89c9ae2d69f0fd9d4e955896489d78cf8795337. f89c9ae2d69f0fd9d4e955896489d78cf8795337 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/49057c5035734b93839de6e8d063cfa0...9615eafe28ee4157821596dcfa07061e/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4604f65ec2c040f4959fdc270c1f4f6b...5bea6c2003284d989bb8c2665dd96b9b/)
[Failed :arrow_down:0.38% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5b17bca2fe054e8ca8fc3fe1567f1ae2...5f795916a4bb4f789c97b623788bb3d2/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a120e60210f74a57a5ee623e5652d751...98c1cde9d30f43c68a308d4e3d6dc366/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/574| `f89c9ae2` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/562| `f89c9ae2` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/560| `f89c9ae2` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/572| `f89c9ae2` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/573| `61655b34` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/561| `61655b34` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/559| `61655b34` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/571| `61655b34` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org