You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/12 17:56:12 UTC
[GitHub] williaster opened a new pull request #6089: [cypress][sqllab]
increase timeout for sqllab results
williaster opened a new pull request #6089: [cypress][sqllab] increase timeout for sqllab results
URL: https://github.com/apache/incubator-superset/pull/6089
This increases the timeout waiting for SQL lab results table from the `Cypress` default of `4s` to `10s`.
Although the test is not flaky locally, you can see from the local Cypress UI that the saved query pane takes some time to load (not sure why). Note I've already added explicit `cy.wait('@sqlLabQuery')` route alias wait statements [as Cypress recommends](https://docs.cypress.io/guides/references/best-practices.html#Unnecessary-wait-for-cy-get), so hopefully this timeout will reduce the overall flakiness on CI.
<img width="500" src="https://user-images.githubusercontent.com/4496521/46885621-5aea4780-ce0d-11e8-84e2-f6c6b65c9af1.png" />
@kristw @graceguo-supercat @xtinec
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org