You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2023/07/28 17:14:19 UTC
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20280
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
When CatalogD HA is enabled, standby catalogd does not receive catalog
topic updates from statestore and does not apply catalog updates from
the active catalogd. Its min topic version is not changed.
Function Statestore::GetMinSubscriberTopicVersion() loops through all
subscribers to find min topic version. Standby catalogd causes
min topic version not increased, and hence Impala server waits
indefinitely in ImpalaServer::WaitForCatalogUpdateTopicPropagation().
This patch fixed the issue by skipping standby catalogd when finding min
topic version in Statestore::GetMinSubscriberTopicVersion().
Testing:
- Added unit-test code for CatalogD HA to run DDL with SYNC_DDL as 1.
Verified that test cases hang without fix, and test cases were passed
after fix.
- Passed test_catalogd_ha.py.
Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
---
M be/src/statestore/statestore.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/20280/1
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
When CatalogD HA is enabled, standby catalogd does not receive catalog
topic updates from statestore and does not apply catalog updates from
the active catalogd. Its min topic version is not changed.
Function Statestore::GetMinSubscriberTopicVersion() loops through all
subscribers to find min topic version. Standby catalogd causes
min topic version not increased, and hence Impala server waits
indefinitely in ImpalaServer::WaitForCatalogUpdateTopicPropagation().
This patch fixed the issue by skipping standby catalogd when finding min
topic version in Statestore::GetMinSubscriberTopicVersion().
Testing:
- Added unit-test code for CatalogD HA to run DDL with SYNC_DDL as 1.
Verified that test cases hang without fix, and test cases were passed
after fix.
- Passed test_catalogd_ha.py.
Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Reviewed-on: http://gerrit.cloudera.org:8080/20280
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/statestore/statestore.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Andrew Sherman: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
When CatalogD HA is enabled, standby catalogd does not receive catalog
topic updates from statestore and does not apply catalog updates from
the active catalogd. Its min topic version is not changed.
Function Statestore::GetMinSubscriberTopicVersion() loops through all
subscribers to find min topic version. Standby catalogd causes
min topic version not increased, and hence Impala server waits
indefinitely in ImpalaServer::WaitForCatalogUpdateTopicPropagation().
This patch fixed the issue by skipping standby catalogd when finding min
topic version in Statestore::GetMinSubscriberTopicVersion().
Testing:
- Added unit-test code for CatalogD HA to run DDL with SYNC_DDL as 1.
Verified that test cases hang without fix, and test cases were passed
after fix.
- Passed test_catalogd_ha.py.
Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
---
M be/src/statestore/statestore.cc
M tests/custom_cluster/test_catalogd_ha.py
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/20280/2
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 2: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 17:46:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py
File tests/custom_cluster/test_catalogd_ha.py:
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@58
PS1, Line 58:
> flake8: E251 unexpected spaces around keyword / parameter equals
fixed
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@58
PS1, Line 58:
> flake8: E251 unexpected spaces around keyword / parameter equals
fixed
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@96
PS1, Line 96:
> flake8: E251 unexpected spaces around keyword / parameter equals
fixed
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@96
PS1, Line 96:
> flake8: E251 unexpected spaces around keyword / parameter equals
fixed
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@162
PS1, Line 162:
> flake8: E251 unexpected spaces around keyword / parameter equals
fixed
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@162
PS1, Line 162:
> flake8: E251 unexpected spaces around keyword / parameter equals
fixed
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 17:23:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13664/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 17:48:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9540/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 17:53:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13663/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 17:37:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 22:09:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12323: DDL hang with SYNC DDL=1 when CatalogD HA enabled
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20280 )
Change subject: IMPALA-12323: DDL hang with SYNC_DDL=1 when CatalogD HA enabled
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py
File tests/custom_cluster/test_catalogd_ha.py:
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@58
PS1, Line 58:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@58
PS1, Line 58:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@96
PS1, Line 96:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@96
PS1, Line 96:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@162
PS1, Line 162:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/20280/1/tests/custom_cluster/test_catalogd_ha.py@162
PS1, Line 162:
flake8: E251 unexpected spaces around keyword / parameter equals
--
To view, visit http://gerrit.cloudera.org:8080/20280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie559c711078f32171dfb2d2e2fda54773c0927c3
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jul 2023 17:15:27 +0000
Gerrit-HasComments: Yes