You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/20 08:16:45 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #9243: Clean up flaky test BatchSourceExecutorTest

eolivelli opened a new pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243


   BatchSourceExecutorTest is often failing on CI
   
   ```
   [org.testng.internal.thread.ThreadTimeoutException: Method org.apache.pulsar.functions.source.batch.BatchSourceExecutorTest.testLifeCycle() didn't finish within the time-out 5000
   at org.testng.internal.MethodInvocationHelper.invokeWithTimeoutWithNewExecutor(MethodInvocationHelper.java:371)
   at org.testng.internal.MethodInvocationHelper.invokeWithTimeout(MethodInvocationHelper.java:282)
   at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:605)
   at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
   at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
   at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
   at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
   at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
   at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
   at java.util.ArrayList.forEach(ArrayList.java:1257)
   at org.testng.TestRunner.privateRun(TestRunner.java:764)
   at org.testng.TestRunner.run(TestRunner.java:585)
   at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
   at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
   at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
   at org.testng.SuiteRunner.run(SuiteRunner.java:286)
   at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
   at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
   at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
   at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
   at org.testng.TestNG.runSuites(TestNG.java:1069)
   at org.testng.TestNG.run(TestNG.java:1037)
   at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:135)
   at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112)
   at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeLazy(TestNGDirectoryTestSuite.java:123)
   at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:90)
   at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
   at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
   at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
   at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
   at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
   ```
   
   This patch cleans up the test case and adds "AfterMethod(alwaysRun=true)" to other two test classes inside the same module.
   I am also removing the "timeout" from a couple of tests.
   Such tests are based on mockito, they do not start external services or perform IO, it is not worth to add a timeout, such tests are pretty easy and their execution should be predictable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9243: Clean up flaky test BatchSourceExecutorTest

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243#issuecomment-763467766


   The failed test is not related to this patch
   
   java.lang.AssertionError: expected [true] but found [false]
   	at org.testng.Assert.fail(Assert.java:99)
   	at org.testng.Assert.failNotEquals(Assert.java:1037)
   	at org.testng.Assert.assertTrue(Assert.java:45)
   	at org.testng.Assert.assertTrue(Assert.java:55)
   	at org.apache.pulsar.tests.integration.functions.PulsarStateTest.testSourceState(PulsarStateTest.java:122)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #9243: Clean up flaky test BatchSourceExecutorTest

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9243: Clean up flaky test BatchSourceExecutorTest

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243#issuecomment-763723688


   @rdhabalia CI passed, can you please merge ?
   this fix will help stability of PR validation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli edited a comment on pull request #9243: Clean up flaky test BatchSourceExecutorTest

Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243#issuecomment-763723688


   @rdhabalia thanks for your review, as CI passed, can you please merge ?
   this fix will help stability of PR validation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9243: Clean up flaky test BatchSourceExecutorTest

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243#issuecomment-763498078


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9243: Clean up flaky test BatchSourceExecutorTest

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9243:
URL: https://github.com/apache/pulsar/pull/9243#issuecomment-763516016


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org