You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2020/08/01 02:15:15 UTC

[kudu-CR] Block Bloom filter false positive rate correction

Hello Tidy Bot, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16248

to look at the new patch set (#6).

Change subject: Block Bloom filter false positive rate correction
......................................................................

Block Bloom filter false positive rate correction

Block Bloom filters have a higher false positive rate than standard
Bloom filter, due to the uneven distribution of keys between
buckets. This patch changes the code to match the theory, using an
approximation from the paper that introduced block Bloom filters.

Change-Id: I58a5191ee86edfa6e4f415829a6a647f586e9af6
---
M src/kudu/util/block_bloom_filter-test.cc
M src/kudu/util/block_bloom_filter.cc
2 files changed, 99 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/16248/6
-- 
To view, visit http://gerrit.cloudera.org:8080/16248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58a5191ee86edfa6e4f415829a6a647f586e9af6
Gerrit-Change-Number: 16248
Gerrit-PatchSet: 6
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)