[jira] [Commented] (WICKET-3759) Touch the page only when it is just read from the page store

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043275#comment-13043275 ] 

Martin Grigorov commented on WICKET-3759:
-----------------------------------------

Link to the mail discussion: http://markmail.org/thread/dbisvrxc4r4bqbud

> Touch the page only when it is just read from the page store
> ------------------------------------------------------------
>
>                 Key: WICKET-3759
>                 URL: https://issues.apache.org/jira/browse/WICKET-3759
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.5-RC4
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC5
>
>         Attachments: WICKET-3759.patch
>
>
> Currently PageProvider#getPageInstance() "touches" the page for each call, i.e. schedules it to be persisted at the end of the request life. This always goes to PageAccessSynchronizer#touchPage() and respectively #lockPage().
> With the suggested patch this will be done at most once per PageProvider#getPage().
> This change causes some tests related to error pages to fail. The problem is that ALWAYS_REDIRECT is used for error pages thus REDIRECT_TO_RENDER strategy which expects the page to be stored before the redirect. Changing it to AUTO_REDIRECT leads to the default REDIRECT_TO_BUFFER to be used and the problem is solved because the response is buffered in the special map and the page is not needed after the redirect.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira