You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/04 19:42:28 UTC
[GitHub] [pulsar] rdhabalia opened a new pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
rdhabalia opened a new pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831
### Motivation
We are frequently getting 500 on `pulsar-admin topics list <ns>` cli command. It happens because `pulsar-admin topics` rest-api internally uses `pulsar-admin` to get list of non-persistent topics. `PulsarAdmin-HttpClient` crates persistent connection but it doesn't perform auto-cert refresh so, if cert is expired and reconnection happens then broker always gets 500 when it uses `pulsar-admin` internally due to invalid certs.
```
21:09:16.025 [AsyncHttpClient-48-9] ERROR org.apache.pulsar.broker.admin.v1.NonPersistentTopics - [role] Failed to get list of topics under namespace prop/cluster/ns
java.util.concurrent.ExecutionException: org.apache.pulsar.client.admin.PulsarAdminException: java.net.ConnectException: error:10000416:SSL routines:OPENSSL_internal:SSLV3_ALERT_CERTIFICATE_UNKNOWN
at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395) ~[?:?]
at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999) ~[?:?]
at org.apache.pulsar.broker.admin.v1.NonPersistentTopics.lambda$getList$0(NonPersistentTopics.java:211) ~[pulsar-broker.jar:]
at java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:930) ~[?:?]
at java.util.concurrent.CompletableFuture$UniHandle.tryFire(CompletableFuture.java:907) ~[?:?]
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?]
at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088) ~[?:?]
at org.apache.pulsar.client.admin.internal.NonPersistentTopicsImpl$4.failed(NonPersistentTopicsImpl.java:215) ~[pulsar-client-admin-original.jar:]
at org.glassfish.jersey.client.JerseyInvocation$4.failed(JerseyInvocation.java:1030) ~[jersey-client-2.27.jar:?]
at org.glassfish.jersey.client.ClientRuntime.processFailure(ClientRuntime.java:231) ~[jersey-client-2.27.jar:?]
at org.glassfish.jersey.client.ClientRuntime.access$100(ClientRuntime.java:85) ~[jersey-client-2.27.jar:?]
at org.glassfish.jersey.client.ClientRuntime$2.lambda$failure$1(ClientRuntime.java:183) ~[jersey-client-2.27.jar:?]
at org.glassfish.jersey.internal.Errors$1.call(Errors.java:272) [jersey-common-2.27.jar:?]
at org.glassfish.jersey.internal.Errors$1.call(Errors.java:268) [jersey-common-2.27.jar:?]
at org.glassfish.jersey.internal.Errors.process(Errors.java:316) [jersey-common-2.27.jar:?]
at org.glassfish.jersey.internal.Errors.process(Errors.java:298) [jersey-common-2.27.jar:?]
at org.glassfish.jersey.internal.Errors.process(Errors.java:268) [jersey-common-2.27.jar:?]
```
### Modification
Add Capability in HttpClient to perform auto-cert refresh to avoid any tls handshake failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-749169358
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia removed a comment on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia removed a comment on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-749236529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-749240167
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-749236529
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-749296146
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia removed a comment on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia removed a comment on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-740077954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-740176743
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8831: [pulsar-broker] Perform auto cert refresh for Pulsar-admin
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8831:
URL: https://github.com/apache/pulsar/pull/8831#issuecomment-740077954
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org