[GitHub] [incubator-apisix] membphis commented on issue #1244: bug: plugin basic-auth needs required field

[GitBox <gi...@apache.org>]

membphis commented on issue #1244: bug: plugin basic-auth needs required field
URL: https://github.com/apache/incubator-apisix/issues/1244#issuecomment-598574032
 
 
   For all of the authorization plugin:
   
   When it was used with `consumer`, it is necessary to provide specific authentication information.
   
   When it was used with `route / service`, we don't need any parameters, just enable or disable this plugin.
   
   So I think the current way is right.
   
   How about this `schema` definition? Is it better?
   
   ```lua
   oneof = {
       -- no parameter
       required = {}, 
       -- two parameters
       required = {"username", "passwd"}
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services