You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/30 20:40:33 UTC
[PR] fix(amber): reject invalid dashboard resource type [texera]
carloea2 opened a new pull request, #8144:
URL: https://github.com/apache/texera/pull/8144
### What changes were proposed in this PR?
Map an unknown dashboard `resourceType` to `BadRequestException` instead of an unhandled `IllegalArgumentException`. Update the existing invalid-type regression coverage for the HTTP-facing exception.
Before: unknown resource type returned 500.
After: unknown resource type returns 400 with a specific message.
### Any related issues, documentation, discussions?
Closes #8143
### How was this PR tested?
- `sbt "WorkflowExecutionService / Test / testOnly org.apache.texera.web.resource.dashboard.DashboardResourceSpec"`
- `sbt scalafmtCheckAll`
- `sbt "scalafixAll --check"`
- Built with `bin/local-dev.sh up texera-web --build --json` and ran the generated distribution on localhost.
- Verified `resourceType=bogus` returns 400 with `Unknown resource type: bogus` and `resourceType=workflow` still returns 200.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-6400646817
@Yicong-Huang, this is still approved with green required checks and no open review threads. Could you merge it when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "mengw15 (via GitHub) via notifications" <no...@texera.apache.org>.
mengw15 merged PR #8144:
URL: https://github.com/apache/texera/pull/8144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5471133661
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Neilk1021`, `@aglinxinyuan`
You can notify them by mentioning `@Neilk1021`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5471197628
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8144?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 94.02%. Comparing base ([`98588bf`](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b1489fb`](https://app.codecov.io/gh/apache/texera/commit/b1489fb582abcc9ac9987771b61063a48d5ba06e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8144 +/- ##
============================================
- Coverage 94.03% 94.02% -0.01%
+ Complexity 4762 4761 -1
============================================
Files 1181 1181
Lines 47877 47877
Branches 5324 5324
============================================
- Hits 45020 45016 -4
- Misses 1433 1436 +3
- Partials 1424 1425 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.00% <100.00%> (-0.03%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.68% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.87% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8144?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #8144:
URL: https://github.com/apache/texera/pull/8144#discussion_r3890821689
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -104,7 +104,7 @@ object DashboardResource {
val q3 = ProjectSearchQueryBuilder.constructQuery(uid, params, includePublic)
val q4 = DatasetSearchQueryBuilder.constructQuery(uid, params, includePublic)
q1.unionAll(q3).unionAll(q4)
- case _ => throw new IllegalArgumentException(s"Unknown resource type: ${params.resourceType}")
+ case _ => throw new BadRequestException(s"Unknown resource type: ${params.resourceType}")
Review Comment:
The Scaladoc at :57 has drifted from the arm this line just turned into a contract: it advertises `"file"` as an acceptable `resourceType` and omits `"dataset"`, which is the reverse of what the dispatch does. `SearchQueryBuilder.FILE_RESOURCE_TYPE = "file"` still exists as a constant with no arm referencing it.
Before this PR the contradiction was between a doc and an unhandled crash; now it is between a doc and a deliberate 400, which is what makes it worth a line.
Not reachable from the product — `search.component.ts:64` narrows `selectedType` to `"workflow" | "dataset" | null` and the typed pages hardcode their own values, so only the `SearchService` type unions still carry `"file"`. Documentation and a dead constant, no runtime path.
##########
amber/src/test/scala/org/apache/texera/web/resource/dashboard/DashboardResourceSpec.scala:
##########
@@ -25,6 +25,7 @@ import org.apache.texera.web.resource.dashboard.DashboardResource.SearchQueryPar
import org.jooq.impl.{DSL => JDSL}
import org.jooq.{OrderField, SQLDialect}
+import javax.ws.rs.BadRequestException
Review Comment:
This sits above the `org.scalatest.*` imports, splitting the `org.*` group in two. The repo groups `java`/`javax` last — see `DashboardResource.scala:22-33`, and both sibling specs importing this same class (`FeedbackResourceSpec.scala:29-34`, `UserConfigResourceSpec.scala:27-30`).
Neither gate catches it: scalafmt is pinned at 2.6.4 with no `rewrite.rules`, and `.scalafix.conf` runs only `ProcedureSyntax` + `RemoveUnused`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on code in PR #8144:
URL: https://github.com/apache/texera/pull/8144#discussion_r3896990297
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -104,7 +104,7 @@ object DashboardResource {
val q3 = ProjectSearchQueryBuilder.constructQuery(uid, params, includePublic)
val q4 = DatasetSearchQueryBuilder.constructQuery(uid, params, includePublic)
q1.unionAll(q3).unionAll(q4)
- case _ => throw new IllegalArgumentException(s"Unknown resource type: ${params.resourceType}")
+ case _ => throw new BadRequestException(s"Unknown resource type: ${params.resourceType}")
Review Comment:
Updated the resource type docs to list dataset instead of file.
##########
amber/src/test/scala/org/apache/texera/web/resource/dashboard/DashboardResourceSpec.scala:
##########
@@ -25,6 +25,7 @@ import org.apache.texera.web.resource.dashboard.DashboardResource.SearchQueryPar
import org.jooq.impl.{DSL => JDSL}
import org.jooq.{OrderField, SQLDialect}
+import javax.ws.rs.BadRequestException
Review Comment:
Moved the javax import below the org imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5471164106
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 2 worse · ⚪ 11 noise (<±5%) · 0 without baseline
> Compared against main `98588bf` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33334317504)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| ⚪ | bs=10 sw=10 sl=64 | 390 | 0.238 | 25,107/35,881/35,881 us | ⚪ within ±5% / 🔴 +142.6% |
| 🟢 | bs=100 sw=10 sl=64 | 785 | 0.479 | 124,112/153,722/153,722 us | 🟢 -5.6% / 🔴 +52.3% |
| 🔴 | bs=1000 sw=10 sl=64 | 914 | 0.558 | 1,091,414/1,208,007/1,208,007 us | 🔴 +5.4% / 🔴 +24.8% |
<details><summary>Baseline details</summary>
Latest main `98588bf` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 390 tuples/sec | 396 tuples/sec | 844.57 tuples/sec | -1.5% | -53.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.241 MB/s | 0.515 MB/s | -1.2% | -53.8% |
| bs=10 sw=10 sl=64 | p50 | 25,107 us | 24,385 us | 11,837 us | +3.0% | +112.1% |
| bs=10 sw=10 sl=64 | p95 | 35,881 us | 36,579 us | 14,788 us | -1.9% | +142.6% |
| bs=10 sw=10 sl=64 | p99 | 35,881 us | 36,579 us | 17,651 us | -1.9% | +103.3% |
| bs=100 sw=10 sl=64 | throughput | 785 tuples/sec | 797 tuples/sec | 1,084 tuples/sec | -1.5% | -27.6% |
| bs=100 sw=10 sl=64 | MB/s | 0.479 MB/s | 0.487 MB/s | 0.662 MB/s | -1.6% | -27.6% |
| bs=100 sw=10 sl=64 | p50 | 124,112 us | 120,939 us | 94,505 us | +2.6% | +31.3% |
| bs=100 sw=10 sl=64 | p95 | 153,722 us | 162,813 us | 100,941 us | -5.6% | +52.3% |
| bs=100 sw=10 sl=64 | p99 | 153,722 us | 162,813 us | 108,642 us | -5.6% | +41.5% |
| bs=1000 sw=10 sl=64 | throughput | 914 tuples/sec | 929 tuples/sec | 1,119 tuples/sec | -1.6% | -18.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.558 MB/s | 0.567 MB/s | 0.683 MB/s | -1.6% | -18.3% |
| bs=1000 sw=10 sl=64 | p50 | 1,091,414 us | 1,066,595 us | 924,404 us | +2.3% | +18.1% |
| bs=1000 sw=10 sl=64 | p95 | 1,208,007 us | 1,146,354 us | 967,785 us | +5.4% | +24.8% |
| bs=1000 sw=10 sl=64 | p99 | 1,208,007 us | 1,146,354 us | 995,630 us | +5.4% | +21.3% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,513.03,200,128000,390,0.238,25106.67,35881.28,35881.28
1,100,10,64,20,2548.50,2000,1280000,785,0.479,124112.02,153721.66,153721.66
2,1000,10,64,20,21885.44,20000,12800000,914,0.558,1091414.42,1208006.76,1208006.76
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-6203576378
@Yicong-Huang, the refreshed checks are green. Could you take a final look and merge when ready? The stale fix label should be feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-6410107415
@Yicong-Huang Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5805549341
I reproduced the CI failure locally. WorkflowResourceSpec still expected IllegalArgumentException after this PR changed it to BadRequestException. Updated that assertion in 6802e98122. Both resource suites now pass all 87 tests, and scalafixAll --check and scalafmtCheckAll pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub) via notifications" <no...@texera.apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-6621013519
@mengw15, this PR is approved, all required checks are green, and there are no open review threads. Could you merge it when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5482795173
Updates are in and CI is green. Ready to merge when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5545675137
Amber CI failed in unrelated WorkflowResourceSpec. The dashboard tests passed. Could someone rerun the failed job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): reject invalid dashboard resource type [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-5471133421
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala`, `amber/src/test/scala/org/apache/texera/web/resource/dashboard/DashboardResourceSpec.scala`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33334307871)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): reject invalid dashboard resource type [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8144:
URL: https://github.com/apache/texera/pull/8144#issuecomment-6392183652
@Yicong-Huang, all required checks are green and there are no open review threads. Your approval is still in place. Could you take a final look and merge when ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org